feat: update metrics receiving logic from sglang scheduler#1883
Closed
zixuanzhang226 wants to merge 1 commit intoai-dynamo:bytedance/metricsfrom
Closed
feat: update metrics receiving logic from sglang scheduler#1883zixuanzhang226 wants to merge 1 commit intoai-dynamo:bytedance/metricsfrom
zixuanzhang226 wants to merge 1 commit intoai-dynamo:bytedance/metricsfrom
Conversation
Contributor
|
👋 Hi zixuanzhang226! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
3b070da to
9f3a67c
Compare
Contributor
|
Merged this code in with proper attribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Updated the metrics receiving logic to align with the latest upstream changes in WorkerMetricsPublisher.publish() and related data structures. This ensures compatibility and correctness when processing metrics from the SGLang scheduler.
Details:
Based on the latest upstream changes to WorkerMetricsPublisher.publish() and the corresponding data structures, I’ve updated the logic for receiving metrics from the SGLang scheduler. I’ve tested the changes and confirmed that the corresponding metrics are being received correctly.
Related PRs:
#1789
#1465