Merged
Conversation
ai
reviewed
Oct 23, 2023
| import open from 'open' | ||
| import {join} from 'path' | ||
| import rm from 'size-limit/rm' | ||
| import { afterEach, expect, it, vi } from "vitest" |
Owner
There was a problem hiding this comment.
Can you run Prettier on changed files?
I have it in VS Code. But you can install to the project, run, and uninstall.
Contributor
Author
There was a problem hiding this comment.
Ah, damn, I did eslint --fix but forgot about prettier. I've installed it globally and ran pnpm exec prettier **/*.js --write, should do the trick.
ai
reviewed
Oct 23, 2023
packages/esbuild/test/index.test.js
Outdated
| }) | ||
|
|
||
| describe('throws error on unknown entry', () => { | ||
| it('should work with commonjs config', async () => { |
Owner
There was a problem hiding this comment.
Suggested change
| it('should work with commonjs config', async () => { | |
| it('works with commonjs config', async () => { |
and all other tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#227
type: moduleto all package.json filestype: modulein their respective package.json files it broke some tests, because the bundlers started treating the files as esm and not cjs like before. That's why I've split the fixtures directories and added package.json files to force the correct module type during bundling tests.import ... assertsyntaxNotes:
if (stmt) { it(...) }toit.skipIf(!stmt)( ... )so it looks a bit cleaner and the runner reports these tests as skipped