Fix outdated info and links in README#566
Merged
Merged
Conversation
- Update size comparison from 130 to 118 bytes (matches actual size-limit) - Remove duplicate collision calculator link with outdated URL - Use ESM import instead of require() in customRandom example - Update React useId link to react.dev (reactjs.org is legacy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few corrections in the main README:
[ID collision probability]definition (line 277) which pointed to the oldalex7kom.github.ioURL — the correctzelark.github.iodefinition on line 229 already covers itrequire('nanoid')toimport ... from 'nanoid'in the Custom Random Bytes Generator section since nanoid v5 is ESM-onlyuseIdlink from legacyreactjs.orgtoreact.dev