Skip to content

reduce bundlesize by moving from while to reduce#355

Merged
ai merged 2 commits intoai:mainfrom
artalar:artalar-reduce-bundlesize
Apr 18, 2022
Merged

reduce bundlesize by moving from while to reduce#355
ai merged 2 commits intoai:mainfrom
artalar:artalar-reduce-bundlesize

Conversation

@artalar
Copy link
Copy Markdown
Contributor

@artalar artalar commented Apr 18, 2022

No description provided.

@artalar artalar force-pushed the artalar-reduce-bundlesize branch from 42ce734 to a584cfd Compare April 18, 2022 09:06
@ai
Copy link
Copy Markdown
Owner

ai commented Apr 18, 2022

😍😍😍

@artalar artalar force-pushed the artalar-reduce-bundlesize branch from 0f0b7c7 to 3937ce9 Compare April 18, 2022 09:21
@artalar
Copy link
Copy Markdown
Contributor Author

artalar commented Apr 18, 2022

Just forcepushed another commit, thats all now :)

@ai ai merged commit f4e7325 into ai:main Apr 18, 2022
@ai
Copy link
Copy Markdown
Owner

ai commented Apr 18, 2022

Thanks. Released in 3.3.3.

@levrik
Copy link
Copy Markdown

levrik commented Apr 19, 2022

I'm wondering how the move from while to reduce affects performance. Method calls tend to be more expensive.

@ai
Copy link
Copy Markdown
Owner

ai commented Apr 19, 2022

@levrik it is micro-optimization (especially in the case of browser version, Node.js version uses while).

Changes will not affect real results.

@ai
Copy link
Copy Markdown
Owner

ai commented Apr 19, 2022

@levrik I looked in benchmark (pnpm start to benchmark browser version) and didn’t find any changed before and after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants