Additional patches for apache#31608#427
Merged
ahmedabu98 merged 19 commits intoahmedabu98:pubsub_orderingkey_writefrom Sep 11, 2024
Merged
Additional patches for apache#31608#427ahmedabu98 merged 19 commits intoahmedabu98:pubsub_orderingkey_writefrom
ahmedabu98 merged 19 commits intoahmedabu98:pubsub_orderingkey_writefrom
Conversation
3 tasks
ahmedabu98
reviewed
Jun 24, 2024
Owner
ahmedabu98
left a comment
There was a problem hiding this comment.
Thanks again @sjvanrossum! Left some comments
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
ahmedabu98
reviewed
Sep 10, 2024
Owner
ahmedabu98
left a comment
There was a problem hiding this comment.
Thanks Steven, sorry for the delay on this review.
Left a couple comments and will reply to the other threads now
Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
42b68fa to
0968242
Compare
0968242 to
a97f64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ahmedabu98 these can either be rebased or merged without squashing so reviewers can look at the individual commits on the thread for apache#31608.
I'm double checking test coverage and may add a few more where needed.
Tested this in Dataflow with a snapshot JAR and everything is running smooth. :)