Skip to content

Work around CPython bug in HTTPError#58

Merged
agronholm merged 4 commits intoagronholm:mainfrom
Zac-HD:httperror-workaround
Mar 12, 2023
Merged

Work around CPython bug in HTTPError#58
agronholm merged 4 commits intoagronholm:mainfrom
Zac-HD:httperror-workaround

Conversation

@Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Mar 12, 2023

Workaround for python/cpython#98778 (aka python/cpython#90113), in order to fix pytest-dev/pytest#10797.

This is a little ugly but I thought we'd prefer to keep it tightly scoped rather than suppressing anything raised by getattr().

@coveralls
Copy link

coveralls commented Mar 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4399424903

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 236 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 65.224%
Files with Coverage Reduction New Missed Lines %
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_exceptions.py 1 89.86%
/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/exceptiongroup/_formatting.py 45 69.68%
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/exceptiongroup/_formatting.py 45 69.87%
/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/exceptiongroup/_formatting.py 46 69.87%
/opt/hostedtoolcache/PyPy/3.8.16/x64/lib/pypy3.8/site-packages/exceptiongroup/_formatting.py 99 16.99%
Totals Coverage Status
Change from base Build 4115259050: -0.3%
Covered Lines: 2065
Relevant Lines: 3166
💛 - Coveralls

@Zac-HD Zac-HD mentioned this pull request Mar 12, 2023
Closed
@agronholm
Copy link
Owner

agronholm commented Mar 12, 2023

I'm a bit confused. There was only a new test added?

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Mar 12, 2023

I wanted to see CI fail on old versions before pushing the fix, and... it's not failing yet 😅

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Mar 12, 2023

@agronholm done, albeit with two more commits than I'd planned.

@agronholm agronholm merged commit 95b7819 into agronholm:main Mar 12, 2023
@agronholm
Copy link
Owner

agronholm commented Mar 12, 2023

Thanks!

@agronholm
Copy link
Owner

agronholm commented Mar 12, 2023

I almost missed the wrong hyperlink format in the changelog. Fixing.

@agronholm
Copy link
Owner

agronholm commented Mar 12, 2023

Released v1.1.1.

@perrinjerome perrinjerome mentioned this pull request Jan 11, 2024
Closed
@Zac-HD Zac-HD deleted the httperror-workaround branch January 12, 2024 05:41
@Zac-HD Zac-HD mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rendering the traceback of an HTTPError causes in INTERNALERROR

3 participants

@Zac-HD @coveralls @agronholm