fix nested shareable in arrays (python decoder only)#267
Merged
agronholm merged 4 commits intoagronholm:masterfrom Dec 18, 2025
Merged
fix nested shareable in arrays (python decoder only)#267agronholm merged 4 commits intoagronholm:masterfrom
agronholm merged 4 commits intoagronholm:masterfrom
Conversation
Owner
|
Please fix the pre-commit errors. |
Contributor
Author
|
Will do. |
Owner
|
Thanks again! |
Owner
|
Do you have more PRs coming in the short term, or should I cut a new release now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Python decoder's decode_array() was not passing unshared=True when decoding array items, unlike decode_map() which correctly does this. This allowed nested shareable tags (tag 28) inside arrays to overwrite _share_index, causing subsequent shared references (tag 29) to resolve to the wrong object.
The C decoder already handles this correctly.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchdocs/), in case of behavior changes or newfeatures
docs/versionhistory.rst).Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.