Skip to content

Add Cherry Pick (#4291)#4295

Merged
gongmax merged 1 commit intoagones-dev:release-1.52.2from
Sivasankaran25:feature/cherry-pick
Oct 1, 2025
Merged

Add Cherry Pick (#4291)#4295
gongmax merged 1 commit intoagones-dev:release-1.52.2from
Sivasankaran25:feature/cherry-pick

Conversation

@Sivasankaran25
Copy link
Copy Markdown
Collaborator

@Sivasankaran25 Sivasankaran25 commented Oct 1, 2025

  • Updates the build scripts to allow for a patch release

  • Linter fixes

  • Removes restore cache from the post_cloudbuild >

The cache key is generated based on a checksum of the dependency manifest files.
The CI process for the main branch is what populates this cache. If the manifests
are the same this would pull caches that are based off the main branch instead of
the release branch.

Removing the cache prioritizes a clean build over speed.

  • Separates out the release-branch creation for minor and patch Makes updates so that the release-branch creation happens before the rest of the release process.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@igooch @Sivasankaran25
Updates the build scripts to allow for a patch release (agones-dev#4291)
89980e5 
* Updates the build scripts to allow for a patch release

* Linter fixes

* Removes restore cache from the post_cloudbuild >
> The cache key is generated based on a checksum of the dependency manifest files.
> The CI process for the main branch is what populates this cache. If the manifests
> are the same this would pull caches that are based off the main branch instead of
> the release branch.
>
> Removing the cache prioritizes a clean build over speed.

* Separates out the release-branch creation for minor and patch
Makes updates so that the release-branch creation happens before the rest of the release process.
@Sivasankaran25 Sivasankaran25 requested a review from igooch October 1, 2025 21:17
@Sivasankaran25 Sivasankaran25 self-assigned this Oct 1, 2025
igooch
igooch approved these changes Oct 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch requested a review from gongmax October 1, 2025 21:21
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Oct 1, 2025

Build Succeeded 🥳

Build Id: 8f0ebcba-05ed-44f1-9a59-5ae59072541e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4295/head:pr_4295 && git checkout pr_4295
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.2-dev-89980e5

@gongmax gongmax merged commit 18d8c4d into agones-dev:release-1.52.2 Oct 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gongmax gongmax gongmax approved these changes

@igooch igooch igooch approved these changes

Assignees

@Sivasankaran25 Sivasankaran25

Labels

kind/other size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sivasankaran25 @agones-bot @gongmax @igooch