Patch-releasev1.52.1#4286
Conversation
…ystem/grpc-gateway/v2 (agones-dev#4270) * fix broken websocket connection after upgrading github.com/grpc-ecosystem/grpc-gateway/v2 * add comment explaining the issue at hand * use the request body instead of an empty one * make sure conformance tests errors are captured * use go mod replacement for websocket hotfix --------- Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>
|
Build Failed 😭 Build Id: 4704254a-240f-490f-b6a9-c28795e8fc5c Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
igooch
left a comment
There was a problem hiding this comment.
Looks like the install/helm/agones/values.yaml also needs to be updated to 1.52.1. Once that's updated from the build directory run make gen-install to update the install/yaml/install.yaml file.
ddbfb72 to
045d0ae
Compare
|
Build Succeeded 🥳 Build Id: 214a9fa4-58b7-424f-8485-371e8307d3b6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
igooch
left a comment
There was a problem hiding this comment.
A few last items.
Looks like there's two lingering references to 1.52.0 that should be updated to 1.52.1:
And then the one comment below that the name of the branch is still release-1.52.0.
site/config.toml
Outdated
|
|
||
| # current release branch. Never is rc. | ||
| release_branch = "release-1.52.0" | ||
| release_branch = "release-1.52.1" |
There was a problem hiding this comment.
| release_branch = "release-1.52.1" | |
| release_branch = "release-1.52.0" |
We're using the release-1.52.0 branch, and not creating a new one, so this should stay the same.
|
Build Succeeded 🥳 Build Id: 4120ddef-fbe3-47a8-96c3-888f54d7499b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: b9555e71-b97f-4cfd-8d14-fa4b59f48e11 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind release
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Works on #4284
Special notes for your reviewer: