Skip to content

Patch-releasev1.52.1#4286

Merged
igooch merged 5 commits intoagones-dev:release-1.52.0from
Sivasankaran25:release-1.52.1
Sep 26, 2025
Merged

Patch-releasev1.52.1#4286
igooch merged 5 commits intoagones-dev:release-1.52.0from
Sivasankaran25:release-1.52.1

Conversation

@Sivasankaran25
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Works on #4284

Special notes for your reviewer:

@github-actions github-actions bot added kind/release Checklist for a release size/L labels Sep 25, 2025
…ystem/grpc-gateway/v2 (agones-dev#4270)

* fix broken websocket connection after upgrading github.com/grpc-ecosystem/grpc-gateway/v2

* add comment explaining the issue at hand

* use the request body instead of an empty one

* make sure conformance tests errors are captured

* use go mod replacement for websocket hotfix

---------

Co-authored-by: Thomas Lacroix <thomas.lacroix@ubisoft.com>
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 4704254a-240f-490f-b6a9-c28795e8fc5c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the install/helm/agones/values.yaml also needs to be updated to 1.52.1. Once that's updated from the build directory run make gen-install to update the install/yaml/install.yaml file.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 214a9fa4-58b7-424f-8485-371e8307d3b6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4286/head:pr_4286 && git checkout pr_4286
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.1-dev-045d0ae

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last items.

Looks like there's two lingering references to 1.52.0 that should be updated to 1.52.1:

https://github.com/googleforgames/agones/blob/d68370de95ce2fc06faada76ebbb1c4b41a108ca/cloudbuild.yaml#L427

https://github.com/googleforgames/agones/blob/d68370de95ce2fc06faada76ebbb1c4b41a108ca/sdks/unity/package.json#L3

And then the one comment below that the name of the branch is still release-1.52.0.

site/config.toml Outdated

# current release branch. Never is rc.
release_branch = "release-1.52.0"
release_branch = "release-1.52.1"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
release_branch = "release-1.52.1"
release_branch = "release-1.52.0"

We're using the release-1.52.0 branch, and not creating a new one, so this should stay the same.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 4120ddef-fbe3-47a8-96c3-888f54d7499b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4286/head:pr_4286 && git checkout pr_4286
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.1-dev-a7f1ecc

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: b9555e71-b97f-4cfd-8d14-fa4b59f48e11

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4286/head:pr_4286 && git checkout pr_4286
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.1-dev-9b76737

@igooch igooch merged commit 2a6fe8d into agones-dev:release-1.52.0 Sep 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/release Checklist for a release size/L size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants