Feat: update error fields from processor proto#4266
Merged
markmandel merged 3 commits intoagones-dev:mainfrom Sep 7, 2025
Merged
Feat: update error fields from processor proto#4266markmandel merged 3 commits intoagones-dev:mainfrom
markmandel merged 3 commits intoagones-dev:mainfrom
Conversation
Collaborator
|
Build Succeeded 🥳 Build Id: 57fccb24-ec91-421c-89df-5790ba06d9da The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Succeeded 🥳 Build Id: eee77c55-6883-4ac7-bd52-d384f91b40da The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Succeeded 🥳 Build Id: 5921fa0c-f8aa-424b-a5dc-2687296c354c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Update the processor proto, to have better error handling, by using the rpc.Status type instead of a single string for the error
I've manually added:
proto/googleapis/google/rpc/status.proto, seems that it was already done forproto/googleapis/google/api/*but I needed the status oneWhich issue(s) this PR fixes:
Part of #4190
Special notes for your reviewer: