Updates the upgrade test to print any fatal error messages to the job pod termination log#4252
Conversation
|
Build Failed 😭 Build Id: e1078bc5-96e5-4126-a0a1-4f8923b9a5f5 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
12f7096 to
e3f0ba9
Compare
… pod termination log. The package is refactored to pass back any fatal errors, cancel context, and cleanup resources on a fatal error.Additional wait timeouts are added to prevent the test from hanging.
|
Build Succeeded 🥳 Build Id: 22431f1a-4709-43ce-bb99-c935bb702b52 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
left a comment
There was a problem hiding this comment.
I trust your knowledge of this code way more than I trust mine -- I assume this is good to go 😄
| job_pods=$(kubectl get pods -l job-name=upgrade-test-runner -o jsonpath="{.items[*].metadata.name}") | ||
| if [[ -z "$job_pods" ]]; then | ||
| echo "No pods found for job upgrade-test-runner. They might have failed to schedule or were deleted." | ||
|
|
There was a problem hiding this comment.
(non blocking meta) - this bash script is at a point where it probably should be a go script 😄
|
Build Failed 😭 Build Id: 18bf8c84-5a94-40cd-b03f-a93008f624d4 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: c2326dee-4752-41f5-9b99-4a1f4bb93a91 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
The upgrade main.go is refactored to pass back any fatal errors, cancel context, and cleanup resources on a fatal error. This way we can see exactly what Fatal error caused the test to fail. This will not include all failure scenarios (i.e. our recent failure scenario of a finalizer not being removed from the ping service), but will still make it easier to debug.
Additional wait timeouts are added to prevent the test from hanging.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer: