feat: use gameservers.lists.maxItems instead of a hardcoded limit by miai10 · Pull Request #4246 · agones-dev/agones

miai10 · 2025-08-13T20:07:19Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

The number of items in a list are bounded to the hardcoded value of 1000. During load tests, this value seems too low so a mechanism to configure it was put in place using Helm values. The default is still 1000 to be backwards compatible.

Which issue(s) this PR fixes:

Closes #4192

Special notes for your reviewer:

miai10 · 2025-08-13T20:09:42Z

Using the make gen-install command returns an error because the .Values.agones.crds.gameserver.lists.maxItems value is nil. It is suppose to use the value from the values file. Not sure why is that, still investigating but let me know if somebody has an idea...

The complete error:

`root@2ddf739d200f:/workspaces/agones/build# make gen-install

mkdir -p ~/.kube/
mkdir -p /workspaces/agones/build//.gocache
mkdir -p /workspaces/agones/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
make ensure-image IMAGE_TAG=agones-build:419ba293a7 BUILD_TARGET=build-build-image
make[1]: Entering directory '/workspaces/agones/build'
make[1]: Leaving directory '/workspaces/agones/build'
docker run --rm -v /workspaces/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspaces/agones:/go/src/agones.dev/agones -v /workspaces/agones/build//.gomod:/go/pkg/mod -v /workspaces/agones/build//.gocache:/root/.cache/go-build agones-build:419ba293a7 bash -c
'helm template agones-manual --namespace agones-system /go/src/agones.dev/agones/install/helm/agones
--set agones.controller.generateTLS=false
--set agones.allocator.generateTLS=false
--set agones.allocator.generateClientTLS=false
--set agones.crds.cleanupOnDelete=false
> /go/src/agones.dev/agones/install/yaml/install.yaml'
Error: template: agones/templates/crds/gameserverset.yaml:117:22: executing "agones/templates/crds/gameserverset.yaml" at <include "gameserver.schema" $data>: error calling include: template: agones/templates/crds/_gameserverspecschema.yaml:194:33: executing "gameserver.schema" at <.Values.agones.crds.gameserver.lists.maxItems>: nil pointer evaluating interface {}.agones`

miai10 · 2025-08-13T20:51:56Z

Using the make gen-install command returns an error because the .Values.agones.crds.gameserver.lists.maxItems value is nil. It is suppose to use the value from the values file. Not sure why is that, still investigating but let me know if somebody has an idea...

The complete error:

`root@2ddf739d200f:/workspaces/agones/build# make gen-install

mkdir -p ~/.kube/ mkdir -p /workspaces/agones/build//.gocache mkdir -p /workspaces/agones/build//.config/gcloud mkdir -p ~/.config/helm mkdir -p ~/.cache/helm make ensure-image IMAGE_TAG=agones-build:419ba293a7 BUILD_TARGET=build-build-image make[1]: Entering directory '/workspaces/agones/build' make[1]: Leaving directory '/workspaces/agones/build' docker run --rm -v /workspaces/agones/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspaces/agones:/go/src/agones.dev/agones -v /workspaces/agones/build//.gomod:/go/pkg/mod -v /workspaces/agones/build//.gocache:/root/.cache/go-build agones-build:419ba293a7 bash -c 'helm template agones-manual --namespace agones-system /go/src/agones.dev/agones/install/helm/agones --set agones.controller.generateTLS=false --set agones.allocator.generateTLS=false --set agones.allocator.generateClientTLS=false --set agones.crds.cleanupOnDelete=false > /go/src/agones.dev/agones/install/yaml/install.yaml' Error: template: agones/templates/crds/gameserverset.yaml:117:22: executing "agones/templates/crds/gameserverset.yaml" at <include "gameserver.schema" $data>: error calling include: template: agones/templates/crds/_gameserverspecschema.yaml:194:33: executing "gameserver.schema" at <.Values.agones.crds.gameserver.lists.maxItems>: nil pointer evaluating interface {}.agones`

Thanks, @lacroixthomas for the help to fix this!

miai10 · 2025-08-13T20:53:41Z

install/yaml/install.yaml

This change is not related to my changes but this is how the new install.yaml file got regenerated

install/helm/agones/templates/crds/fleet.yaml

lacroixthomas · 2025-08-18T16:56:57Z

/gcbrun

agones-bot · 2025-08-18T18:22:06Z

Build Succeeded 🥳

Build Id: 50854079-a8d7-433c-a210-e8119671a0d3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-a2341e7
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-a2341e7
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-a2341e7-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-a2341e7
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-a2341e7
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-a2341e7
Linux C++ SDK (build): agonessdk-1.52.0-dev-a2341e7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-a2341e7.zip

A preview of the website (the last 30 builds are retained):

https://a2341e7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4246/head:pr_4246 && git checkout pr_4246
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-a2341e7

miai10 · 2025-08-25T08:12:53Z

@markmandel @lacroixthomas : let me know if this needs more work or we should merge it

markmandel · 2025-08-25T15:30:19Z

I'm back from devcom and Gamescom - I can peek at this shortly!

miai10 · 2025-09-01T14:41:52Z

@markmandel, @lacroixthomas: please don't forget about this one

site/content/en/docs/Installation/Install Agones/helm.md

lacroixthomas · 2025-09-02T13:18:44Z

Other than Mark's comment, LGTM !

lacroixthomas · 2025-09-02T14:03:41Z

/gcbrun

agones-bot · 2025-09-02T15:03:54Z

Build Succeeded 🥳

Build Id: bc1af87a-bf2b-420a-ae76-572c286526c1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-cd6ecbb
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-cd6ecbb
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-cd6ecbb-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-cd6ecbb
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-cd6ecbb
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-cd6ecbb
Linux C++ SDK (build): agonessdk-1.52.0-dev-cd6ecbb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-cd6ecbb.zip

A preview of the website (the last 30 builds are retained):

https://cd6ecbb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4246/head:pr_4246 && git checkout pr_4246
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-cd6ecbb

markmandel · 2025-09-02T15:18:35Z

/gcbrun

agones-bot · 2025-09-02T16:14:43Z

Build Succeeded 🥳

Build Id: a729389c-8455-4569-8469-88b0dc6d954d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-be0d6f3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-be0d6f3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-be0d6f3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-be0d6f3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-be0d6f3
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-be0d6f3
Linux C++ SDK (build): agonessdk-1.52.0-dev-be0d6f3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-be0d6f3.zip

A preview of the website (the last 30 builds are retained):

https://be0d6f3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4246/head:pr_4246 && git checkout pr_4246
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-be0d6f3

github-actions bot added kind/feature New features for Agones size/S labels Aug 13, 2025

miai10 commented Aug 13, 2025

View reviewed changes

miai10 changed the title ~~WIP: Using agones.crds.gameserver.lists.maxItems instead of a hardcoded limit~~ feat: use agones.crds.gameserver.lists.maxItems instead of a hardcoded limit Aug 14, 2025

lacroixthomas reviewed Aug 14, 2025

View reviewed changes

install/helm/agones/templates/crds/fleet.yaml Outdated Show resolved Hide resolved

miai10 changed the title ~~feat: use agones.crds.gameserver.lists.maxItems instead of a hardcoded limit~~ feat: use gameservers.lists.maxItems instead of a hardcoded limit Aug 18, 2025

markmandel reviewed Sep 1, 2025

View reviewed changes

site/content/en/docs/Installation/Install Agones/helm.md Show resolved Hide resolved

miai10 added 5 commits September 2, 2025 16:59

Using agones.crds.gameserver.lists.maxItems instead of a hardcoded limit

f3facc7

Fix gen-install

f12ce87

Update docs

175a42f

Use gameservers.lists.maxItems instead

880a2fa

Fix docs

cd6ecbb

miai10 force-pushed the perf/lists-limit branch from 5e0771a to cd6ecbb Compare September 2, 2025 13:59

markmandel approved these changes Sep 2, 2025

View reviewed changes

markmandel enabled auto-merge (squash) September 2, 2025 15:17

Merge branch 'main' into perf/lists-limit

be0d6f3

markmandel merged commit 7011c5b into agones-dev:main Sep 2, 2025
4 checks passed

igooch mentioned this pull request Sep 22, 2025

sdkserver UpdateList does not respect gameservers.lists.maxItems #4282

Closed

Conversation

miai10 commented Aug 13, 2025

Uh oh!

miai10 commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miai10 commented Aug 13, 2025

Uh oh!

miai10 Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lacroixthomas commented Aug 18, 2025

Uh oh!

agones-bot commented Aug 18, 2025

Uh oh!

miai10 commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markmandel commented Aug 25, 2025

Uh oh!

miai10 commented Sep 1, 2025

Uh oh!

Uh oh!

lacroixthomas commented Sep 2, 2025

Uh oh!

lacroixthomas commented Sep 2, 2025

Uh oh!

agones-bot commented Sep 2, 2025

Uh oh!

markmandel commented Sep 2, 2025

Uh oh!

agones-bot commented Sep 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miai10 commented Aug 13, 2025 •

edited

Loading

miai10 commented Aug 25, 2025 •

edited

Loading