Update Helm option for spec.strategy.type for controller and extensio… by Sivasankaran25 · Pull Request #4244 · agones-dev/agones

Sivasankaran25 · 2025-08-13T08:40:08Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4198

Special notes for your reviewer:

…ns-deployment

agones-bot · 2025-08-13T11:56:21Z

Build Failed 😭

Build Id: 385d019f-9c0e-417c-bee5-804496af968b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-08-17T15:40:50Z

/gcbrun

agones-bot · 2025-08-17T16:41:06Z

Build Succeeded 🥳

Build Id: fb8f3d70-b878-4543-8e5f-b2cd6dfb182c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-0479138
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-0479138
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-0479138-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-0479138
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-0479138
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-0479138
Linux C++ SDK (build): agonessdk-1.52.0-dev-0479138-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-0479138.zip

A preview of the website (the last 30 builds are retained):

https://0479138-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4244/head:pr_4244 && git checkout pr_4244
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-0479138

igooch

One small change, otherwise LGTM.

install/helm/agones/values.yaml

agones-bot · 2025-08-19T05:11:22Z

Build Succeeded 🥳

Build Id: 46b71a54-316a-4a54-b8f1-99e2098556fd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-5b19b2e
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-5b19b2e
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-5b19b2e-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-5b19b2e
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-5b19b2e
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-5b19b2e
Linux C++ SDK (build): agonessdk-1.52.0-dev-5b19b2e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-5b19b2e.zip

A preview of the website (the last 30 builds are retained):

https://5b19b2e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4244/head:pr_4244 && git checkout pr_4244
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-5b19b2e

agones-bot · 2025-08-19T05:53:28Z

Build Failed 😭

Build Id: 82f55117-aeeb-43fc-a398-686028bbd9a8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-08-19T06:25:44Z

/gcbrun

agones-bot · 2025-08-19T07:02:49Z

Build Failed 😭

Build Id: f0bc1fe2-f5f2-4e56-8680-463443cc89fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-08-19T08:45:58Z

/gcbrun

agones-bot · 2025-08-19T09:19:33Z

Build Failed 😭

Build Id: 1e3f76c1-6ae5-4038-b2b6-785744393712

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-08-19T15:23:04Z

/gcbrun

agones-bot · 2025-08-19T16:19:31Z

Build Succeeded 🥳

Build Id: 59100c41-8a3b-426c-97e6-5a111109914a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-b401d4d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-b401d4d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-b401d4d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-b401d4d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-b401d4d
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-b401d4d
Linux C++ SDK (build): agonessdk-1.52.0-dev-b401d4d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-b401d4d.zip

A preview of the website (the last 30 builds are retained):

https://b401d4d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4244/head:pr_4244 && git checkout pr_4244
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-b401d4d

igooch

LGTM

Update Helm option for spec.strategy.type for controller and extensio…

0b8f539

…ns-deployment

Sivasankaran25 requested review from gongmax and igooch August 13, 2025 08:40

github-actions bot added kind/feature New features for Agones size/S labels Aug 13, 2025

Sivasankaran25 self-assigned this Aug 13, 2025

Merge branch 'main' into add_helm_feature

231f6de

Merge branch 'main' into add_helm_feature

0479138

igooch requested changes Aug 18, 2025

View reviewed changes

install/helm/agones/values.yaml Show resolved Hide resolved

Sivasankaran25 added 2 commits August 19, 2025 09:48

Merge branch 'main' into add_helm_feature

5b19b2e

add update strategy object in controller and extensions

b401d4d

igooch approved these changes Aug 19, 2025

View reviewed changes

igooch merged commit fd0d7d1 into agones-dev:main Aug 19, 2025
4 checks passed

Conversation

Sivasankaran25 commented Aug 13, 2025

Uh oh!

agones-bot commented Aug 13, 2025

Uh oh!

Sivasankaran25 commented Aug 17, 2025

Uh oh!

agones-bot commented Aug 17, 2025

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agones-bot commented Aug 19, 2025

Uh oh!

agones-bot commented Aug 19, 2025

Uh oh!

Sivasankaran25 commented Aug 19, 2025

Uh oh!

agones-bot commented Aug 19, 2025

Uh oh!

Sivasankaran25 commented Aug 19, 2025

Uh oh!

agones-bot commented Aug 19, 2025

Uh oh!

Sivasankaran25 commented Aug 19, 2025

Uh oh!

agones-bot commented Aug 19, 2025

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants