WasmAutoscaler feature gate and prep build image#4243
WasmAutoscaler feature gate and prep build image#4243markmandel merged 3 commits intoagones-dev:mainfrom
Conversation
|
LGTM |
|
Build Failed 😭 Build Id: b827909e-adb1-4f56-a9a1-0d87ade1767a Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Huh, dont see "Step 24: wait-to-become-leader" fail much these days. /gcbrun |
|
Build Failed 😭 Build Id: 6d19f6e5-f653-4e2f-ab82-6653984b8eae Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 21579110-cb32-4168-8585-0734ddece1c3 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
| PlayerAllocationFilter: false | ||
| PlayerTracking: false | ||
| SidecarContainers: false | ||
| WasmAutoscaler: false |
There was a problem hiding this comment.
Should we start this under "dev"?
There was a problem hiding this comment.
Ooops! I thought I moved it. I'll move it down.
|
Build Succeeded 🥳 Build Id: b8bc7948-0759-4d05-ba27-0205a64ae2ad The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: ba299485-5a3e-4d22-b8fe-3ff9b501e7c5 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 987ee39b-b7b9-4b2e-92c8-1a9114b89c6c Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
- Add FeatureWasmAutoscaler feature gate - Install Extism CLI and libraries in build image to aid in development This sets up the scaffolding for a script-based (WASM) FleetAutoscaler while keeping it disabled by default behind a feature gate. Work on agones-dev#4080
Co-authored-by: igooch <igooch@google.com>
c377ff8 to
8cad9ea
Compare
|
This should be good to go now, as soon as it passed CI. |
lacroixthomas
left a comment
There was a problem hiding this comment.
Tiny change otherwise LGTM
8cad9ea to
121e08b
Compare
|
@igooch looks like the upgrade test is failing again. e2e passed. |
|
Back to square one, will have a look 😄 |
|
Build Failed 😭 Build Id: c6382dab-587a-406b-8c2c-aeac9b965df7 Status: TIMEOUT To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Might be because of the issue from 1.33, the fact that it cannot delete the service and then the helm release, would be great to check if we can upgrade the version 1.33 if the fix is available |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This sets up the scaffolding for a script-based (WASM) FleetAutoscaler while keeping it disabled by default behind a feature gate.
Which issue(s) this PR fixes:
Work on #4080
Special notes for your reviewer:
More to come!