feat: add processor proto by lacroixthomas · Pull Request #4227 · agones-dev/agones

lacroixthomas · 2025-07-24T21:21:17Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Add processor proto + update makefile

Which issue(s) this PR fixes:

Part of #4190

Special notes for your reviewer:

lacroixthomas · 2025-07-24T21:21:40Z

This is still in work in progress, quite some stuff to fix / cleanup / doc

agones-bot · 2025-07-24T22:30:14Z

Build Failed 😭

Build Id: 3b16d165-56f0-4d3a-a410-2822c01b1f23

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

miai10 · 2025-07-25T11:52:50Z

If you have some time, you could create a sequence diagram with the messages exchange to improve the documentation of this new part of the project

lacroixthomas · 2025-07-25T14:05:23Z

If you have some time, you could create a sequence diagram with the messages exchange to improve the documentation of this new part of the project

I was thinking to write the doc at the end: #4190 (comment)
But I can link a mermaid diagram as a comment here if wanted ?

miai10 · 2025-07-29T07:57:00Z

If you have some time, you could create a sequence diagram with the messages exchange to improve the documentation of this new part of the project

I was thinking to write the doc at the end: #4190 (comment) But I can link a mermaid diagram as a comment here if wanted ?

I was thinking that any piece of design doc is valuable to be reviewed right now.

For me it is a bit unclear how the pull batches system will work. For example how will the leader processor know from which allocator address to pull from? If one allocator is replaced, how is it autodetected?

lacroixthomas · 2025-07-29T11:55:50Z

Understood, this PR is mainly for the pull effect streaming with gRPC for the proto, but all the logic around how it would communicate would be on another PR when ill implement a client and server for it

If you're fine with it, I can add more info / diagram on the issue direclty until I start the task for the doc and the implementation of the client server ?

I added more info on the original issue: #4190 (comment)

agones-bot · 2025-07-30T21:21:19Z

Build Failed 😭

Build Id: ab7a2f09-29e2-42b9-bee7-5406e3ada4c1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-07-31T01:32:35Z

/gcbrun

agones-bot · 2025-07-31T01:37:42Z

Build Failed 😭

Build Id: 69934201-16da-44ae-9fff-d13337b6bfab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-07-31T02:28:34Z

Build Failed 😭

Build Id: 48b7137d-0de2-48f7-b1c5-c110e72ba184

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-07-31T16:46:30Z

Build Failed 😭

Build Id: 04601fb4-90f7-4fa0-9c59-d5fdf9d4e09b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-07-31T17:32:18Z

/gcbrun

markmandel · 2025-07-31T17:32:46Z

Shouldn't be affecting submit-upgrade-test-cloud-build - it's just being flaky as per usual.

agones-bot · 2025-07-31T18:30:17Z

Build Succeeded 🥳

Build Id: d9834f2d-5570-4146-8331-94e7f5c5321e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.51.0-dev-cc9acf9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.51.0-dev-cc9acf9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.51.0-dev-cc9acf9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.51.0-dev-cc9acf9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.51.0-dev-cc9acf9
Linux C++ SDK (build): agonessdk-1.51.0-dev-cc9acf9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.51.0-dev-cc9acf9.zip

A preview of the website (the last 30 builds are retained):

https://cc9acf9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4227/head:pr_4227 && git checkout pr_4227
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-cc9acf9

agones-bot · 2025-08-01T17:32:15Z

Build Succeeded 🥳

Build Id: 2ff1c28d-8f9d-404d-95d8-d1303d401677

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-2a5de70
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-2a5de70
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-2a5de70-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-2a5de70
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-2a5de70
Linux C++ SDK (build): agonessdk-1.52.0-dev-2a5de70-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-2a5de70.zip

A preview of the website (the last 30 builds are retained):

https://2a5de70-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4227/head:pr_4227 && git checkout pr_4227
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-2a5de70

markmandel

Looks good, just a non blocking question.

markmandel · 2025-08-03T22:24:27Z

proto/allocation/processor.proto

+  // The responses is a repeated field of AllocationResponse messages.
+  repeated allocation.AllocationResponse responses = 1;
+
+  // The errors is a repeated field of error messages.


(Non blocking question): I assume errors are index based? so an error at errors[4] aligns with reposnses[4], and an empty error string is no error?

Yep, exactly

markmandel

Looks good, just a non blocking question.

agones-bot · 2025-08-04T01:38:24Z

Build Failed 😭

Build Id: 8a3c8a5f-e2a6-4820-b7ba-87ee35fb68f8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-08-04T05:04:54Z

/gcbrun

agones-bot · 2025-08-04T05:41:05Z

Build Failed 😭

Build Id: 09e17944-c04f-46cb-8132-33f127302ea2

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-08-04T13:53:33Z

/gcbrun

agones-bot · 2025-08-04T14:53:39Z

Build Succeeded 🥳

Build Id: 8b400ee0-d1b6-4e36-ae21-92710cb8a3bf

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-1b2bcd4
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-1b2bcd4
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-1b2bcd4-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-1b2bcd4
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-1b2bcd4
Linux C++ SDK (build): agonessdk-1.52.0-dev-1b2bcd4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-1b2bcd4.zip

A preview of the website (the last 30 builds are retained):

https://1b2bcd4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4227/head:pr_4227 && git checkout pr_4227
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-1b2bcd4

feat: add processor proto

fc1671f

github-actions bot added kind/feature New features for Agones size/L labels Jul 24, 2025

feat: add comments

3bfadd2

lacroixthomas marked this pull request as ready for review July 29, 2025 13:33

Merge branch 'main' into features/add-processor-proto

6d9c73a

lacroixthomas mentioned this pull request Jul 29, 2025

[Feature Proposal] - Improve allocator HA to favor packing sessions into multi sessions servers #4190

Open

lacroixthomas changed the title ~~feat: add processor proto (Work in progress)~~ feat: add processor proto Jul 29, 2025

Merge branch 'main' into features/add-processor-proto

36caccc

Merge branch 'main' into features/add-processor-proto

cc9acf9

Merge branch 'main' into features/add-processor-proto

2a5de70

markmandel reviewed Aug 3, 2025

View reviewed changes

markmandel approved these changes Aug 3, 2025

View reviewed changes

markmandel enabled auto-merge (squash) August 3, 2025 22:38

Merge branch 'main' into features/add-processor-proto

1b2bcd4

markmandel merged commit a5f9d08 into agones-dev:main Aug 4, 2025
4 checks passed

lacroixthomas mentioned this pull request Aug 13, 2025

Approver request #4245

Closed

5 tasks

Conversation

lacroixthomas commented Jul 24, 2025

Uh oh!

lacroixthomas commented Jul 24, 2025

Uh oh!

agones-bot commented Jul 24, 2025

Uh oh!

miai10 commented Jul 25, 2025

Uh oh!

lacroixthomas commented Jul 25, 2025

Uh oh!

miai10 commented Jul 29, 2025

Uh oh!

lacroixthomas commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agones-bot commented Jul 30, 2025

Uh oh!

lacroixthomas commented Jul 31, 2025

Uh oh!

agones-bot commented Jul 31, 2025

Uh oh!

agones-bot commented Jul 31, 2025

Uh oh!

agones-bot commented Jul 31, 2025

Uh oh!

markmandel commented Jul 31, 2025

Uh oh!

markmandel commented Jul 31, 2025

Uh oh!

agones-bot commented Jul 31, 2025

Uh oh!

agones-bot commented Aug 1, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

lacroixthomas Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Aug 4, 2025

Uh oh!

markmandel commented Aug 4, 2025

Uh oh!

agones-bot commented Aug 4, 2025

Uh oh!

lacroixthomas commented Aug 4, 2025

Uh oh!

agones-bot commented Aug 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lacroixthomas commented Jul 29, 2025 •

edited

Loading