Skip to content

fleetautoscaler.md references metadata incorrectly#4217

Merged
markmandel merged 2 commits intoagones-dev:mainfrom
KAllan357:docs/update-fleetautoscaler
Jul 14, 2025
Merged

fleetautoscaler.md references metadata incorrectly#4217
markmandel merged 2 commits intoagones-dev:mainfrom
KAllan357:docs/update-fleetautoscaler

Conversation

@KAllan357
Copy link
Copy Markdown
Contributor

@KAllan357 KAllan357 commented Jul 10, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

I started to write my own Webhook Autoscaler using the documentation as a reference and never saw a metadata key in my scaling requests from Agones. I started researching the codebase and read through #3957 and the associated issues. I think this error in documentation slipped through during the code review and it was not updated to what actually shipped in that PR.

This change updates the documentation to match the struct again.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added kind/documentation Documentation for Agones size/XS labels Jul 10, 2025
@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Jul 11, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Jul 11, 2025

Build Failed 😭

Build Id: 23294625-e612-430d-bb7c-1f6d4a4e656a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Jul 11, 2025

Flake:

    examples_test.go:83: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/examples_test.go:83
        	Error:      	Received unexpected error:
        	            	waiting for {supertuxkart [{default  Dynamic <nil> 8080 0 UDP}] {false 60 0 30}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] [] []} {[] [] [{supertuxkart us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.18 [] []  [] [] [{ENABLE_PLAYER_TRACKING false nil}] {map[] map[] []} [] <nil> [] [] nil nil nil nil    nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] [] <nil> nil <nil> [] [] nil}} <nil> map[] map[] <nil>} GameServer instance readiness timed out (): waiting for GameServer 1752211393/supertuxkart-bjxwp to be Ready: GameServer reached terminal state Unhealthy
        	Test:       	TestSuperTuxKartGameServerReady

Weird.

@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Jul 11, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Jul 11, 2025

Build Succeeded 🥳

Build Id: 21a4dcf5-d417-45a3-a134-35657b2729e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4217/head:pr_4217 && git checkout pr_4217
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-d73d389

markmandel
markmandel approved these changes Jul 13, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@markmandel markmandel enabled auto-merge (squash) July 13, 2025 22:57
@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Jul 13, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Jul 14, 2025

Build Succeeded 🥳

Build Id: ba0558ab-a4bf-4860-a697-6a70d627c215

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4217/head:pr_4217 && git checkout pr_4217
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.51.0-dev-3e991a6

@markmandel markmandel merged commit da1e928 into agones-dev:main Jul 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmandel markmandel markmandel approved these changes

Assignees

No one assigned

Labels

kind/documentation Documentation for Agones size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KAllan357 @markmandel @agones-bot