Skip to content

Specify exit code in simple-game-server CRASH#4196

Merged
markmandel merged 2 commits intoagones-dev:mainfrom
markmandel:example/simple-crash
Jun 2, 2025
Merged

Specify exit code in simple-game-server CRASH#4196
markmandel merged 2 commits intoagones-dev:mainfrom
markmandel:example/simple-crash

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

@markmandel markmandel commented Jun 1, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

This change allows us to recreate the issues with Pods that are in a Succeeded state by providing a CRASH 0 command to the simple game server.

Which issue(s) this PR fixes:

Work on #4188

Special notes for your reviewer:

Once this is built and pushed to prod, I can push up the fixes for #4188.

@markmandel
Specify exit code in simple-game-server CRASH
0bf65a3 
This change allows us to recreate the issues with Pods that are in a
Succeeded state by providing a `CRASH 0` command to the simple game
server.

Work on agones-dev#4188
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Jun 1, 2025
@github-actions github-actions bot added the kind/feature New features for Agones label Jun 1, 2025
@markmandel markmandel requested review from igooch and peterzhongyi June 1, 2025 22:18
@github-actions github-actions bot added the size/S label Jun 1, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Jun 2, 2025

Build Succeeded 🥳

Build Id: 718338ab-f454-4ae8-9f2e-22f7b089f02d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4196/head:pr_4196 && git checkout pr_4196
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-0bf65a3

igooch
igooch approved these changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel enabled auto-merge (squash) June 2, 2025 20:57
@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Jun 2, 2025

Build Succeeded 🥳

Build Id: bd4310d0-8ab1-40d4-9f58-c21b16211faa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4196/head:pr_4196 && git checkout pr_4196
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-1ddc809

@markmandel markmandel merged commit f4b018d into agones-dev:main Jun 2, 2025
4 checks passed
@markmandel markmandel deleted the example/simple-crash branch June 2, 2025 21:50
@markmandel markmandel mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igooch igooch igooch approved these changes

@peterzhongyi peterzhongyi Awaiting requested review from peterzhongyi

Assignees

No one assigned

Labels

area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @igooch