Feat: allow push-chart to custom helm registry#4172
Feat: allow push-chart to custom helm registry#4172markmandel merged 3 commits intoagones-dev:mainfrom
Conversation
|
Build Succeeded 🥳 Build Id: 7059a6fd-a6b2-4630-b223-8be7b60ecfa6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
build/includes/release.mk
Outdated
| # push the current chart to google cloud storage and update the index | ||
| # or push the current charts to the helm registry `CHART_REGISTRY` | ||
| push-chart: $(ensure-build-image) build-chart | ||
| ifdef CHART_REGISTRY |
There was a problem hiding this comment.
My only feedback would be that rather than an ifdef have CHART_REGISTRY set in Makefile with a default value (probably ""), and some description on it. At least then it's with all the other Makefile variables.
Also, it's not _super- up to date, but it would be good if this was documented here: https://github.com/googleforgames/agones/tree/main/build#make-variable-reference
But otherwise, good addition!
|
Build Succeeded 🥳 Build Id: 656c97e5-a680-4e13-a24f-d2367ed84d1f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
left a comment
There was a problem hiding this comment.
Still in draft 😄 you happy to have this merged? If so, I'm happy to approve.
I'll keep it on draft until tomorrow, wanna double check with my pipeline if everything's fine or if I missed something first, ill get it out of draft tomorrow though 😄 |
|
I just double checked, it's good to go, moving out of draft 😄 |
|
Build Succeeded 🥳 Build Id: ff8dcb7f-27b5-40af-9940-9bb7fa7d6cce The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR is to support pushing current chart to a private registry using
CHARTS_REGISTRYIt would help testing within my infra, the
REGISTRYwas already supported to push my builds but the charts were "linked" to theGCP_BUCKET_CHARTSI could run
REGISTRY=... CHART_REGISTRY=... make build-images && make push && make push-chartWhich issue(s) this PR fixes:
Closes #4166
Special notes for your reviewer:
This is currently in WIP, I still need to do more tests around it and also updating the documentation
This would not update the index though, In my opinion it's fine as this is not to replace the main registry but for testing purpose within an infra