Adds permissions in the agones-system namespace for the upgrade tests#4148
Merged
igooch merged 2 commits intoagones-dev:mainfrom Apr 14, 2025
Merged
Adds permissions in the agones-system namespace for the upgrade tests#4148igooch merged 2 commits intoagones-dev:mainfrom
igooch merged 2 commits intoagones-dev:mainfrom
Conversation
Collaborator
|
Build Failed 😭 Build Id: 7836c39d-7275-45a6-a914-65b0649a1798 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Build Failed 😭 Build Id: 9f0c3f5a-87b5-4d4e-8d73-d369a9f0e879 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
Author
|
/gcbrun |
Collaborator
|
Build Succeeded 🥳 Build Id: 12a334ef-2ffb-4db7-9f36-7753dcadf448 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
gongmax
approved these changes
Apr 8, 2025
Collaborator
|
Build Succeeded 🥳 Build Id: 0ea9cb8c-b2d9-4905-9da6-d9954647b291 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
For the upgrade tests Agones is installed by a
job. This means that all permissions for the Agones install must also exist in the job. This is to cleanup errors in the upgrade test like:that are due to the job not having the permissions in the
agones-systemnamespace. The ServiceAccount names added to the permissions are taken directly from theinstall.yamlfile for agones https://github.com/googleforgames/agones/blob/d07dabd7100c2a14717ec902080b59a2fdc399fe/install/yaml/install.yaml#L17720-L17722.Which issue(s) this PR fixes:
NA
Special notes for your reviewer: