Skip to content

Promote PortRanges to Beta#4147

Merged
gongmax merged 2 commits intoagones-dev:mainfrom
kamaljeeti:PortRanges-To-Beta
Apr 10, 2025
Merged

Promote PortRanges to Beta#4147
gongmax merged 2 commits intoagones-dev:mainfrom
kamaljeeti:PortRanges-To-Beta

Conversation

@kamaljeeti
Copy link
Copy Markdown
Contributor

@kamaljeeti kamaljeeti commented Apr 7, 2025

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#4141

Closes #4141

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Apr 7, 2025
@0xaravindh
Copy link
Copy Markdown

0xaravindh commented Apr 7, 2025 •
edited
Loading

@igooch Do we need to update PortRanges & PortPolicyNone in the versionMap.yaml Dev session?

https://github.com/googleforgames/agones/blob/d07dabd7100c2a14717ec902080b59a2fdc399fe/test/upgrade/versionMap.yaml#L96-L98

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Apr 7, 2025

Build Failed 😭

Build Id: 0198c246-79e4-48df-94e4-35e50323f967

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@kamaljeeti
Copy link
Copy Markdown
Contributor Author

kamaljeeti commented Apr 7, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Apr 7, 2025

Build Failed 😭

Build Id: 8f0d3fa5-2bba-42f9-bd41-f4a39ada2a91

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@kamaljeeti kamaljeeti requested review from gongmax and igooch April 7, 2025 08:56
@kamaljeeti
Copy link
Copy Markdown
Contributor Author

kamaljeeti commented Apr 8, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Apr 8, 2025

Build Succeeded 🥳

Build Id: 229dce17-0a09-481f-8e01-5ac8ce3ed536

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4147/head:pr_4147 && git checkout pr_4147
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-91ab457

gongmax
gongmax reviewed Apr 8, 2025
View reviewed changes
site/content/en/docs/Guides/feature-stages.md Outdated
| [Support Passthrough on GKE Autopilot](https://github.com/googleforgames/agones/issues/3721) | `AutopilotPassthroughPort` | Enabled | `Beta` | 1.43.0 |
| [Support for Extended Duration Pods on GKE Autopilot (*1.28+ only*)](https://github.com/googleforgames/agones/issues/3386) | `GKEAutopilotExtendedDurationPods` | Enabled | `Beta` | 1.44.0 |
| [Port Policy None](https://github.com/googleforgames/agones/issues/3804) | `PortPolicyNone` | Enabled | `Beta` | 1.49.0 |
| [Multiple dynamic port ranges](https://github.com/googleforgames/agones/issues/1911) | `PortRanges` | Enabled | `Beta` | 1.49.0 |
Copy link
Copy Markdown
Collaborator

@gongmax gongmax Apr 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both line 35 and 36 should be behind a release guard. eg https://github.com/googleforgames/agones/pull/4138/files#diff-6a76655b1e397b2f3b9955ebe19b8263aa78cd04aed336f6a737d9e408eac30c

Copy link
Copy Markdown
Contributor Author

@kamaljeeti kamaljeeti Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated

@agones-bot
Copy link
Copy Markdown
Collaborator

agones-bot commented Apr 10, 2025

Build Succeeded 🥳

Build Id: e1aec773-6dc6-436c-95f3-2fe977032000

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4147/head:pr_4147 && git checkout pr_4147
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-a13a679

@gongmax gongmax merged commit 81fc712 into agones-dev:main Apr 10, 2025
4 checks passed
@0xaravindh 0xaravindh mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gongmax gongmax gongmax approved these changes

@igooch igooch Awaiting requested review from igooch

Assignees

No one assigned

Labels

kind/feature New features for Agones

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promote Multiple Dynamic Port Ranges Feature PortRanges to Beta

4 participants

@kamaljeeti @0xaravindh @agones-bot @gongmax