fix: ensure fleet autoscaler policy are namespaced by lacroixthomas · Pull Request #4098 · agones-dev/agones

lacroixthomas · 2025-01-24T01:27:31Z

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Ensure the fleet autoscaler policy are namespaced, to ensure it's not autoscaling on all namespaces (on fleet with same name but from different namespaces)

Which issue(s) this PR fixes:
Closes #3954

Special notes for your reviewer:
Did some manual tests following the steps described on the issue.

TODO:

Manual testing
Make sure the syncFleet() and the updateFleet() are also namespaced
Fixed current unit tests

pkg/fleets/fleets.go

pkg/fleetautoscalers/controller.go

0xaravindh · 2025-01-24T05:19:03Z

/gcbrun

agones-bot · 2025-01-24T06:19:32Z

Build Failed 😭

Build Id: ab15f2ec-5595-4ef5-8530-9eddaa897305

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-01-25T16:49:01Z

/gcbrun

agones-bot · 2025-01-25T18:02:14Z

Build Succeeded 🥳

Build Id: 8f343cff-43c4-4726-90fc-d566ff758fbf

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.47.0-dev-e9a8b98
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.47.0-dev-e9a8b98
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.47.0-dev-e9a8b98-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.47.0-dev-e9a8b98
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.47.0-dev-e9a8b98
Linux C++ SDK (build): agonessdk-1.47.0-dev-e9a8b98-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.47.0-dev-e9a8b98.zip

A preview of the website (the last 30 builds are retained):

https://e9a8b98-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-e9a8b98

agones-bot · 2025-02-18T20:18:16Z

Build Succeeded 🥳

Build Id: 2f991fa6-7c3c-4cc0-a929-8e3d8671dc04

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-2b0f5e3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-2b0f5e3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-2b0f5e3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-2b0f5e3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-2b0f5e3
Linux C++ SDK (build): agonessdk-1.48.0-dev-2b0f5e3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-2b0f5e3.zip

A preview of the website (the last 30 builds are retained):

https://2b0f5e3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-2b0f5e3

igooch · 2025-03-03T21:47:31Z

/gcbrun

agones-bot · 2025-03-03T23:00:25Z

Build Succeeded 🥳

Build Id: 9e7638f9-b613-4b48-95b4-e580805204e9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-b7c29c3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-b7c29c3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-b7c29c3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-b7c29c3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-b7c29c3
Linux C++ SDK (build): agonessdk-1.48.0-dev-b7c29c3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-b7c29c3.zip

A preview of the website (the last 30 builds are retained):

https://b7c29c3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-b7c29c3

igooch · 2025-03-10T07:36:53Z

Would you be able to add a test that tests for the issue in the original issue? I.e. a test that ensures that two fleets with the same name in different namespaces scale up independently?

lacroixthomas · 2025-03-10T19:29:55Z

Would you be able to add a test that tests for the issue in the original issue? I.e. a test that ensures that two fleets with the same name in different namespaces scale up independently?

Yes, I'm gonna do that, I would imagine an e2e test ?

Currently, it seems that the namespace is set by the e2eframework, it only expect a single namespace https://github.com/googleforgames/agones/blob/main/test/e2e/framework/framework.go#L168, I can have a look on how to manage multiple ones at the same time

lacroixthomas · 2025-03-10T19:46:25Z

Actually, this could be something similar to the allocator one: https://github.com/googleforgames/agones/blob/main/test/e2e/allocator_test.go#L564C6-L564C33

Will add the e2e test this week

agones-bot · 2025-03-12T18:16:35Z

Build Failed 😭

Build Id: befe7ab2-a697-4304-b7e1-b21f1c692e84

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-03-12T19:57:15Z

My e2e test is not valid, it's also passing on the main branch, will come back to it this week

agones-bot · 2025-03-12T20:11:18Z

Build Succeeded 🥳

Build Id: 1d8aca5a-8571-4098-8da8-6ab3fc5195db

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-95039f3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-95039f3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-95039f3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-95039f3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-95039f3
Linux C++ SDK (build): agonessdk-1.48.0-dev-95039f3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-95039f3.zip

A preview of the website (the last 30 builds are retained):

https://95039f3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-95039f3

agones-bot · 2025-03-12T23:48:42Z

Build Failed 😭

Build Id: f1a3cbca-f1ff-4b76-bbda-5a6d0b0c6f93

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-13T00:45:03Z

Build Failed 😭

Build Id: 3adc7671-a020-4358-8443-da33fe7bb104

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-03-13T18:31:57Z

Build Succeeded 🥳

Build Id: 76745580-f4dc-4969-8996-a3483ca02f71

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-c6e2f3d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-c6e2f3d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-c6e2f3d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-c6e2f3d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-c6e2f3d
Linux C++ SDK (build): agonessdk-1.48.0-dev-c6e2f3d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-c6e2f3d.zip

A preview of the website (the last 30 builds are retained):

https://c6e2f3d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-c6e2f3d

agones-bot · 2025-03-24T21:10:01Z

Build Succeeded 🥳

Build Id: 9a1ee354-e856-460c-ba9d-73c39d91c0b6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-53019ff
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-53019ff
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-53019ff-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-53019ff
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-53019ff
Linux C++ SDK (build): agonessdk-1.48.0-dev-53019ff-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-53019ff.zip

A preview of the website (the last 30 builds are retained):

https://53019ff-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-53019ff

agones-bot · 2025-03-25T20:20:36Z

Build Succeeded 🥳

Build Id: 1d0c1983-4127-46d9-99d6-8a7592751cec

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.48.0-dev-8426e5d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.48.0-dev-8426e5d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-8426e5d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.48.0-dev-8426e5d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.48.0-dev-8426e5d
Linux C++ SDK (build): agonessdk-1.48.0-dev-8426e5d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.48.0-dev-8426e5d.zip

A preview of the website (the last 30 builds are retained):

https://8426e5d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-8426e5d

agones-bot · 2025-04-16T18:04:59Z

Build Failed 😭

Build Id: 71e41609-665d-4bb4-9c6b-55d593464749

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-04-17T19:05:00Z

/gcbrun

agones-bot · 2025-04-17T19:49:06Z

Build Failed 😭

Build Id: 0edf2f1e-e1df-4479-a967-b91f96315c5a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-04-21T04:12:45Z

/gcbrun

agones-bot · 2025-04-21T05:16:36Z

Build Succeeded 🥳

Build Id: 56e8a228-fd33-4d1d-b3a5-27c896d47ce7

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.49.0-dev-565ebc4
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.49.0-dev-565ebc4
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.49.0-dev-565ebc4-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.49.0-dev-565ebc4
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.49.0-dev-565ebc4
Linux C++ SDK (build): agonessdk-1.49.0-dev-565ebc4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.49.0-dev-565ebc4.zip

A preview of the website (the last 30 builds are retained):

https://565ebc4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.49.0-dev-565ebc4

markmandel

LGTM. Nice change.

markmandel · 2025-04-22T02:05:33Z

/gcbrun

agones-bot · 2025-04-22T02:14:42Z

Build Failed 😭

Build Id: b4483729-24a3-4b80-b577-4c6dd1c24bec

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-04-22T02:56:37Z

/gcbrun

agones-bot · 2025-04-22T03:41:05Z

Build Failed 😭

Build Id: 24a30463-ebfc-4c98-a748-0c2712754aa8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions bot added kind/bug These are bugs. size/M labels Jan 24, 2025

lacroixthomas commented Jan 24, 2025

View reviewed changes

pkg/fleets/fleets.go Show resolved Hide resolved

lacroixthomas commented Jan 24, 2025

View reviewed changes

pkg/fleetautoscalers/controller.go Outdated Show resolved Hide resolved

lacroixthomas added 3 commits January 24, 2025 17:03

fix: ensure fleet autoscaler policy are namespaced

76a5cc9

fix: ensure the gameserver sets are also namespaced

3d8c6ff

fix: use namespace from objectMetadata and fix unit tests

e9a8b98

lacroixthomas force-pushed the fix/fleet-autoscaler-not-namespaced branch from b5a6d1a to e9a8b98 Compare January 25, 2025 15:26

lacroixthomas marked this pull request as ready for review January 25, 2025 20:05

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

2b0f5e3

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

b7c29c3

feat: add e2e test to match issue

42c9483

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

95039f3

lacroixthomas added 2 commits March 12, 2025 18:26

feat: update e2e to match issue

e6898b8

feat: update e2e to match issue

1b87280

feat: fix e2e

612f5d1

lacroixthomas marked this pull request as draft March 12, 2025 23:59

lacroixthomas added 3 commits March 13, 2025 13:26

feat: fix e2e

8bc8b73

feat: add comment

82f81a0

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

c6e2f3d

lacroixthomas marked this pull request as ready for review March 13, 2025 17:33

lacroixthomas mentioned this pull request Mar 18, 2025

Fix for flaky TestListAutoscalerAllocated #4128

Closed

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

53019ff

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

8426e5d

Merge branch 'main' into fix/fleet-autoscaler-not-namespaced

73dbbbf

feat: trigger pipeline

565ebc4

markmandel approved these changes Apr 22, 2025

View reviewed changes

markmandel enabled auto-merge (squash) April 22, 2025 02:05

markmandel merged commit 8071954 into agones-dev:main Apr 22, 2025
4 checks passed

lacroixthomas mentioned this pull request Aug 13, 2025

Approver request #4245

Closed

5 tasks

Conversation

lacroixthomas commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xaravindh commented Jan 24, 2025

Uh oh!

agones-bot commented Jan 24, 2025

Uh oh!

markmandel commented Jan 25, 2025

Uh oh!

agones-bot commented Jan 25, 2025

Uh oh!

agones-bot commented Feb 18, 2025

Uh oh!

igooch commented Mar 3, 2025

Uh oh!

agones-bot commented Mar 3, 2025

Uh oh!

igooch commented Mar 10, 2025

Uh oh!

lacroixthomas commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lacroixthomas commented Mar 10, 2025

Uh oh!

agones-bot commented Mar 12, 2025

Uh oh!

lacroixthomas commented Mar 12, 2025

Uh oh!

agones-bot commented Mar 12, 2025

Uh oh!

agones-bot commented Mar 12, 2025

Uh oh!

agones-bot commented Mar 13, 2025

Uh oh!

agones-bot commented Mar 13, 2025

Uh oh!

agones-bot commented Mar 24, 2025

Uh oh!

agones-bot commented Mar 25, 2025

Uh oh!

agones-bot commented Apr 16, 2025

Uh oh!

lacroixthomas commented Apr 17, 2025

Uh oh!

agones-bot commented Apr 17, 2025

Uh oh!

0xaravindh commented Apr 21, 2025

Uh oh!

agones-bot commented Apr 21, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel commented Apr 22, 2025

Uh oh!

agones-bot commented Apr 22, 2025

Uh oh!

markmandel commented Apr 22, 2025

Uh oh!

agones-bot commented Apr 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lacroixthomas commented Jan 24, 2025 •

edited

Loading

lacroixthomas commented Mar 10, 2025 •

edited

Loading