Unreal SDK - Added counters to unreal sdk by GloryOfNight · Pull Request #3935 · agones-dev/agones

GloryOfNight · 2024-08-08T20:58:09Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:
Added counters to unreal sdk

Which issue(s) this PR fixes:
n/a

Closes #3648 (partially)

Special notes for your reviewer:

Validity of http requests not tested.
Build log as requested in CONTRIBUTING.md:

buildWin64Editor.log

google-cla · 2024-08-08T20:58:13Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…nes into feature/unreal-counters

agones-bot · 2024-08-08T22:28:34Z

Build Succeeded 🥳

Build Id: 01fbce8a-8930-430b-845b-454f9acc8cb4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-d8e45eb
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-d8e45eb
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-d8e45eb-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-d8e45eb
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-d8e45eb
Linux C++ SDK (build): agonessdk-1.43.0-dev-d8e45eb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-d8e45eb.zip

A preview of the website (the last 30 builds are retained):

https://d8e45eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-d8e45eb

GloryOfNight · 2024-08-09T09:01:38Z

buildWin64Editor.log

agones-bot · 2024-08-09T09:48:43Z

Build Failed 😭

Build Id: b480c9f0-481a-4ef5-aaf5-b76e25478735

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-13T22:57:37Z

Build Succeeded 🥳

Build Id: 13a8808e-11a7-4104-9cfe-db4a4cbbce36

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-c6ec608
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-c6ec608
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-c6ec608-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-c6ec608
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-c6ec608
Linux C++ SDK (build): agonessdk-1.43.0-dev-c6ec608-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-c6ec608.zip

A preview of the website (the last 30 builds are retained):

https://c6ec608-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-c6ec608

agones-bot · 2024-08-20T12:28:58Z

Build Succeeded 🥳

Build Id: 74231d6b-3a0a-49cc-b5b1-12f866cbbd87

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-98b4524
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-98b4524
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-98b4524-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-98b4524
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-98b4524
Linux C++ SDK (build): agonessdk-1.43.0-dev-98b4524-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-98b4524.zip

A preview of the website (the last 30 builds are retained):

https://98b4524-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-98b4524

igooch · 2024-08-20T22:45:15Z

@tvandijck and @KiaArmani as the most recent contributors to the Unreal SDK, would you review this PR?

zifter · 2024-08-26T19:15:52Z

Any updates? It would be great to have it in 1.43 :)

agones-bot · 2024-08-26T21:22:52Z

Build Succeeded 🥳

Build Id: 54dafa02-7d35-4c2e-b255-65007ec87795

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-bdd95e1
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-bdd95e1
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-bdd95e1-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-bdd95e1
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-bdd95e1
Linux C++ SDK (build): agonessdk-1.43.0-dev-bdd95e1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-bdd95e1.zip

A preview of the website (the last 30 builds are retained):

https://bdd95e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-bdd95e1

igooch · 2024-08-26T22:02:04Z

Any updates? It would be great to have it in 1.43 :)

1.43 release is getting cut in a few hours, so it's probably too close for this release.

@zifter or @KAllan357 would you be able to test and validate the changes in this PR?

zifter · 2024-08-26T23:01:42Z

@igooch I'm working with @GloryOfNight in the same company and these changes are made by my request.

I actually can confirm, that it's tested, because we are using those changes currently in production.

GloryOfNight · 2024-08-27T11:33:01Z

We only using counter decrement. Get/Set Counter is not tested.
I'll give some time to test them to be sure.

KiaArmani

LGTM!

Found an issue with default initialized content string that by default {} (braces). That caused Get req. to fail.

GloryOfNight · 2024-08-27T12:49:58Z

Tested, found issue with GetCounters() call related to default initialized content string as braces. Fixed it.
Everything looks good now.

agones-bot · 2024-08-27T13:53:20Z

Build Succeeded 🥳

Build Id: 9c33eb73-b894-4fca-8c1c-d50494d4ff84

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-b8b37c8
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-b8b37c8
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-b8b37c8-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-b8b37c8
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-b8b37c8
Linux C++ SDK (build): agonessdk-1.43.0-dev-b8b37c8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-b8b37c8.zip

A preview of the website (the last 30 builds are retained):

https://b8b37c8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b8b37c8

zifter

Looks good for me

agones-bot · 2024-09-03T19:59:27Z

Build Succeeded 🥳

Build Id: 9e937153-a4eb-4f57-900c-c909794b5c77

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-25ac6d3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-25ac6d3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-25ac6d3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-25ac6d3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-25ac6d3
Linux C++ SDK (build): agonessdk-1.43.0-dev-25ac6d3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-25ac6d3.zip

A preview of the website (the last 30 builds are retained):

https://25ac6d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-25ac6d3

zifter · 2024-09-06T08:16:19Z

Any updates?

igooch

Approving based on reviews by @KiaArmani and @zifter. Thank you for the contribution!

agones-bot · 2024-09-06T18:25:19Z

Build Succeeded 🥳

Build Id: a435d9bc-db09-4eb1-9577-ff4e14b46998

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.44.0-dev-c5fa1c9
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.44.0-dev-c5fa1c9
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.44.0-dev-c5fa1c9-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.44.0-dev-c5fa1c9
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.44.0-dev-c5fa1c9
Linux C++ SDK (build): agonessdk-1.44.0-dev-c5fa1c9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.44.0-dev-c5fa1c9.zip

A preview of the website (the last 30 builds are retained):

https://c5fa1c9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-c5fa1c9

added counters to unreal sdk

9262d1c

github-actions bot added kind/feature New features for Agones size/M labels Aug 8, 2024

Update unreal.md

e5dabff

GloryOfNight marked this pull request as draft August 8, 2024 21:10

GloryOfNight added 3 commits August 8, 2024 23:20

reduce amount of copy-paste code

a2a6e58

Merge branch 'feature/unreal-counters' of github.com:GloryOfNight/ago…

d602277

…nes into feature/unreal-counters

Fix comments in AgonesComponent.h

d8e45eb

GloryOfNight added 2 commits August 9, 2024 10:57

Update AgonesComponent.cpp

c1fc769

Update AgonesComponent.h

4b11fd1

GloryOfNight marked this pull request as ready for review August 9, 2024 09:01

Merge branch 'main' into feature/unreal-counters

c6ec608

Merge branch 'main' into feature/unreal-counters

98b4524

Merge branch 'main' into feature/unreal-counters

bdd95e1

KiaArmani approved these changes Aug 27, 2024

View reviewed changes

GloryOfNight added 2 commits August 27, 2024 14:48

Fix unreal GetCounter

af563b4

Found an issue with default initialized content string that by default {} (braces). That caused Get req. to fail.

Merge branch 'main' into feature/unreal-counters

b8b37c8

zifter approved these changes Aug 28, 2024

View reviewed changes

Merge branch 'main' into feature/unreal-counters

25ac6d3

KiaArmani approved these changes Sep 6, 2024

View reviewed changes

Merge branch 'main' into feature/unreal-counters

c5fa1c9

igooch approved these changes Sep 6, 2024

View reviewed changes

igooch enabled auto-merge (squash) September 6, 2024 16:34

igooch merged commit 0625ae5 into agones-dev:main Sep 6, 2024

RomekCDPR mentioned this pull request Nov 4, 2024

Add support for lists in Unreal SDK #4029

Closed

Conversation

GloryOfNight commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Aug 8, 2024

Uh oh!

agones-bot commented Aug 8, 2024

Uh oh!

GloryOfNight commented Aug 9, 2024

Uh oh!

agones-bot commented Aug 9, 2024

Uh oh!

agones-bot commented Aug 13, 2024

Uh oh!

agones-bot commented Aug 20, 2024

Uh oh!

igooch commented Aug 20, 2024

Uh oh!

zifter commented Aug 26, 2024

Uh oh!

agones-bot commented Aug 26, 2024

Uh oh!

igooch commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zifter commented Aug 26, 2024

Uh oh!

GloryOfNight commented Aug 27, 2024

Uh oh!

KiaArmani left a comment

Choose a reason for hiding this comment

Uh oh!

GloryOfNight commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agones-bot commented Aug 27, 2024

Uh oh!

zifter left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Sep 3, 2024

Uh oh!

zifter commented Sep 6, 2024

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GloryOfNight commented Aug 8, 2024 •

edited

Loading

igooch commented Aug 26, 2024 •

edited

Loading

GloryOfNight commented Aug 27, 2024 •

edited

Loading