Skip to content

Error handling on client SDK feature "setLabel" #4385

@BlackSheepSpicy

Description

@BlackSheepSpicy

Is your feature request related to a problem? Please describe.
When attempting to submit an invalid label with the REST API. rather than returning a failure response the client SDK will enter an infinite loop of attempting to submit the label without any additional output unless debug logging is enabled, this also disables further creation of labels.

Describe the solution you'd like
Simple failure responses in the form of 400 or 500 response codes with a simple JSON body stating success or failure along with the attempted label key and value.

Describe alternatives you've considered
I did briefly consider monitoring the labels but considering the loop knocks out the set label feature it would be a bit moot, could also force restart the client sdk sidecar somehow but I'm not sure if that will break anything upstream when considering health checking.

Additional context
Infinite label create loop log sample:
Image

Link to the Agones Feature Proposal (if any)
NA

Discussion Link (if any)
https://agones.slack.com/archives/C9DGM5DS8/p1765412391189909

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/user-experiencePertaining to developers trying to use Agones, e.g. SDK, installation, etcgood first issueThese are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!kind/featureNew features for Agones

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions