Skip to content

Fix "ads" not detected in spotify#41

Merged
aghontpi merged 3 commits into
masterfrom
fix-spotify-issue-because-of-language
Mar 30, 2022
Merged

Fix "ads" not detected in spotify#41
aghontpi merged 3 commits into
masterfrom
fix-spotify-issue-because-of-language

Conversation

@aghontpi

Copy link
Copy Markdown
Owner

this pr fixes #29

The issue occurs because of different language locale.

A new file is created for "ad detection", any new words or false positives can be added or removed by changing this file.

app/src/main/java/bluepie/ad_silence/triggers/Spotify.kt

extracted by decompinling the official apk
@aghontpi

Copy link
Copy Markdown
Owner Author

test build (rename to .apk, restrictions in comments)
ad-silence-test-build-29.zip

@aghontpi aghontpi merged commit d693954 into master Mar 30, 2022
@aghontpi aghontpi deleted the fix-spotify-issue-because-of-language branch March 30, 2022 18:19
@unseenlarks

Copy link
Copy Markdown

test build (rename to .apk, restrictions in comments) ad-silence-test-build-29.zip

success! thank you very much. 😃

@unseenlarks

Copy link
Copy Markdown

hi again. just had an ad go through that i'd never seen/heard before on Spotify.
Screenshot_20220620-020147

@aghontpi

aghontpi commented Jul 1, 2022

Copy link
Copy Markdown
Owner Author

@unseenlarks, thanks for the report, did it occur more than once?

should we add this to app/src/main/java/bluepie/ad_silence/triggers/Spotify.kt ?
Screenshot 2022-07-01 at 11 11 54 AM

@unseenlarks

Copy link
Copy Markdown

the full text would be something like 'your song will play after the ad'.

it happened twice during that listening session, but to be fair, i haven't encountered it since. i haven't been listening much this week, but all the other ads i got were muted, as usual.

@aghontpi

aghontpi commented Jul 1, 2022

Copy link
Copy Markdown
Owner Author

the full text would be something like 'your song will play after the ad'.

it happened twice during that listening session, but to be fair, i haven't encountered it since. i haven't been listening much this week, but all the other ads i got were muted, as usual.

this has to be added to new detections, I'll add it

created an issue #59 for the same.

@unseenlarks

Copy link
Copy Markdown

caught this again today, the full ad reads "your song will play after this short message".
spotify-ad

@aghontpi

aghontpi commented Jul 4, 2022

Copy link
Copy Markdown
Owner Author

@unseenlarks thanks, I was able to extract strings for all languages from the latest version, can you check

"Tu canción sonará tras este breve mensaje.",
in #62, some extracted string has . at the end..but others do not. idk which one is correct.

@unseenlarks

unseenlarks commented Jul 4, 2022

Copy link
Copy Markdown

i see "Tu canción se reproducirá después de este breve mensaje". while the above string seems to be for es-rES locale (Spain Spanish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ads not muted on Spotify / Android 8

2 participants