Skip to content

fix: include both stdout and stderr in Bash tool output#456

Merged
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
tbounsiar:fix/bash-stderr-lost
Mar 24, 2026
Merged

fix: include both stdout and stderr in Bash tool output#456
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
tbounsiar:fix/bash-stderr-lost

Conversation

@tbounsiar
Copy link
Copy Markdown
Contributor

@tbounsiar tbounsiar commented Mar 23, 2026

Summary

  • When a Bash tool execution produced both stdout and stderr, only stdout was shown due to the || operator short-circuiting
  • Changed to concatenate both streams with [stdout, stderr].filter(Boolean).join("\n") so error output is no longer silently dropped

Test plan

  • npm run build compiles clean
  • npm run lint passes
  • All 34 tools tests pass

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 23, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tahar BOUNSIAR.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tbounsiar
fix: include both stdout and stderr in Bash tool output
1f13327 
When a Bash tool execution produced both stdout and stderr, only stdout
was shown due to the || operator short-circuiting. This change
concatenates both streams so error output is no longer silently dropped.
@tbounsiar tbounsiar force-pushed the fix/bash-stderr-lost branch from d3cb135 to 1f13327 Compare March 23, 2026 13:17
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 23, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @tbounsiar on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@tbounsiar
Copy link
Copy Markdown
Contributor Author

tbounsiar commented Mar 23, 2026

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 23, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @tbounsiar on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 23, 2026

The cla-bot has been summoned, and re-checked this pull request!

@tbounsiar
Copy link
Copy Markdown
Contributor Author

tbounsiar commented Mar 23, 2026

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Mar 23, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 23, 2026

The cla-bot has been summoned, and re-checked this pull request!

@benbrandt benbrandt enabled auto-merge (squash) March 24, 2026 21:21
@benbrandt benbrandt merged commit d2428a4 into agentclientprotocol:main Mar 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrandt benbrandt benbrandt approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbounsiar @benbrandt