Merged
Conversation
According to the type docs, this should be a more reliable indicator of turn end: > Mirrors notifySessionStateChanged. 'idle' fires after heldBackResult flushes and the bg-agent do-while exits — authoritative turn-over signal.
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 26, 2026
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 26, 2026
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 26, 2026
SteffenDE
added a commit
to SteffenDE/claude-code-acp
that referenced
this pull request
Mar 26, 2026
benbrandt
added a commit
that referenced
this pull request
Mar 26, 2026
#463 introduced a problem with cancelling prompts. Because cancel exited the loop early, the idle session state message was not consumed. Then, in the next prompt, we'd immediately get the idle state and assume it's done. Instead, we always wait for the idle state (and still finish early when detecting a queued prompt). Note that this is based on my tests that showed Claude only sending the idle state when all background agents are done. --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
benbrandt
pushed a commit
that referenced
this pull request
Mar 26, 2026
🤖 I have created a release *beep* *boop* --- ## [0.24.1](v0.24.0...v0.24.1) (2026-03-26) ### Bug Fixes * Cleanup based on new idle state [#463](#463) ([#480](#480)) ([23b3073](23b3073)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the type docs, this should be a more reliable indicator of
turn end: