Fix Kiro authoring JSON completion parity and fixture docs#614
Fix Kiro authoring JSON completion parity and fixture docs#614
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the authoring experience for KiroAgent files by ensuring their proper treatment as JSON for code completion, which includes generating valid JSON syntax for both keys and values. Additionally, it improves the clarity of fixture documentation regarding KiroMcp file type detection. Highlights
Changelog
ActivityUsing Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR aligns Kiro agent authoring completions with JSON syntax and clarifies fixture documentation around Kiro MCP detection, addressing completion parity and fixture-reader confusion.
Changes:
- Treat
FileType::KiroAgentas a JSON family for completion insert text (quoted keys/values). - Add regression tests asserting Kiro agent key/value completions insert valid JSON syntax.
- Update fixture README to clarify that
KiroMcpdetection only targets.kiro/settings/mcp.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/fixtures/README.md |
Clarifies that only .kiro/settings/mcp.json is detected as KiroMcp; other JSON files in that folder are fixture artifacts. |
crates/agnix-core/src/authoring.rs |
Updates JSON-family detection to include KiroAgent and adds tests validating JSON-formatted completion insert text for Kiro agent files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
The pull request correctly updates the is_json_family function to include FileType::KiroAgent, ensuring proper JSON completion behavior for Kiro agents. The accompanying tests validate both value and key completion, confirming that JSON syntax is correctly applied. Additionally, the README.md update provides valuable clarification regarding Kiro MCP file-type detection, improving documentation for fixture artifacts.
Summary
FileType::KiroAgentas a JSON family for completion insert textKiroMcpdetection only targets.kiro/settings/mcp.jsonValidation
cargo fmt --check --allcargo test -p agnix-core authoring::tests::cargo test -p agnix-core --libCloses #612
Closes #613