Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit CI enforcement (“S-tier gate”) for the Kiro target to ensure Kiro-specific behavior and documentation parity are continuously validated on every PR/push, addressing the lack of Kiro coverage in the CI pipeline.
Changes:
- Replaces the main CI workflow job with explicit Rust fmt/clippy/test steps and adds a dedicated Kiro S-tier Gate test invocation.
- Adds a new ignored integration test suite (
kiro_ci_gate) to validate Kiro target behavior, docs parity for Kiro rules, and real-world repo manifest tagging. - Tags a real-world repo entry with an explicit
kirocategory and records the CI gate addition in the changelog.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Implements explicit Rust CI steps and runs the Kiro gate tests on every PR/push. |
crates/agnix-cli/tests/kiro_ci_gate.rs |
Adds Kiro-focused CI gate integration tests (target behavior, docs parity subset, real-world manifest check). |
crates/agnix-cli/Cargo.toml |
Adds serde_yaml as a dev-dependency for parsing the real-world YAML manifest in tests. |
tests/real-world/repos.yaml |
Adds an explicit kiro category tag to ensure manifest coverage is detectable/enforced. |
CHANGELOG.md |
Notes the new Kiro S-tier CI gate. |
Cargo.lock |
Lockfile update due to serde_yaml usage. |
Comments suppressed due to low confidence (4)
crates/agnix-cli/tests/kiro_ci_gate.rs:173
- This Kiro-only VALIDATION-RULES.md parity check appears redundant with
rule_parity.rs::test_rules_json_matches_validation_rules_md()which already enforces that allrules.jsonIDs are present inVALIDATION-RULES.mdand runs undercargo test --workspace. Unless CI is intentionally skipping the global parity test, consider removing this duplicate to reduce maintenance burden.
fn kiro_rules_still_documented_in_validation_rules() {
let rules_path = workspace_root().join("knowledge-base/rules.json");
let rules_content = fs::read_to_string(&rules_path)
.unwrap_or_else(|e| panic!("Failed to read {}: {}", rules_path.display(), e));
let index: RulesIndex = serde_json::from_str(&rules_content)
.github/workflows/ci.yml:40
ci.ymlcurrently only runs fmt/clippy/tests + the Kiro gate, but.github/workflows/README.mddocumentsci.ymlas including “coverage” and “build” as well. If this workflow is intended to replace the sharedci-rust.yml, consider restoring the missing checks (or updating the workflows README to match the new behavior) so CI expectations stay accurate.
- name: Test
run: cargo test --workspace
- name: Kiro S-tier Gate
run: cargo test -p agnix-cli --test kiro_ci_gate -- --include-ignored
crates/agnix-cli/tests/kiro_ci_gate.rs:133
- This
has_non_cc_ruleassertion is redundant/misleading: anyKIRO-*/KR-SK-*diagnostic already satisfies “non-CC”, and you assert those separately. Consider removing this assertion, tightening it to check for a non-Kiro prefix, or rewording the message to reflect what’s actually being validated.
assert!(
has_non_cc_rule,
"With --target kiro, non-CC rules should still run"
);
crates/agnix-cli/tests/kiro_ci_gate.rs:155
- This README Kiro-row check largely duplicates
docs_website_parity.rs::readme_supported_tools_kiro_row_matches_current_rules_surface()(which also validates the rule count derived fromrules.json). Consider reusing/factoring the existing parity assertion (or dropping this one) to avoid having two near-identical checks that can drift independently.
let kiro_row = readme
.lines()
.find(|line| line.starts_with("| [Kiro](https://kiro.dev) |"))
.expect("README.md Supported Tools table must include a Kiro row");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Addressed Copilot review notes in commit 8257ec7:
Unresolved review threads are now at 0 and all checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kiro_ci_gateintegration tests for Kiro target behavior, docs/rule parity, and real-world manifest coverageTesting
Closes #602