fix(zed): remove mdc language definition per upstream review#559
Merged
fix(zed): remove mdc language definition per upstream review#559
Conversation
Remove the custom MDC language from the Zed extension as requested by Zed maintainer. The .mdc suffix should be recognized as Markdown in Zed core instead.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the custom MDC language definition from the Zed extension and updates the extension manifest so the agnix language server no longer registers against a separate “MDC” language, aligning with upstream guidance that .mdc should be handled by Zed core as Markdown.
Changes:
- Delete the Zed language definition for MDC (previously treated as Markdown grammar with
.mdcsuffix). - Remove “MDC” from the
agnix-lsplanguage serverlanguageslist andlanguage_idsmapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| editors/zed/languages/mdc/config.toml | Removes the custom MDC language configuration. |
| editors/zed/extension.toml | Stops advertising/identifying “MDC” as a separate language for LSP activation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.mdcsuffix should be added as a recognized Markdown suffix in Zed core instead.Test plan
languages/directory