Cursor component: improve xrselect rayOrigin logic#5606
Merged
dmarcos merged 2 commits intoaframevr:masterfrom Nov 15, 2024
Merged
Cursor component: improve xrselect rayOrigin logic#5606dmarcos merged 2 commits intoaframevr:masterfrom
dmarcos merged 2 commits intoaframevr:masterfrom
Conversation
Member
|
Thank you! |
Member
|
Tested this on Vision Pro and seems to work as expected. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Continuation of #5528 adding logic to convert the XRPose coming from WebXR into world space. Intended usage of
cursor="rayOrigin: xrselect"is to place it on thea-scene(similar torayOrigin: mouse), but can also be placed elsewhere as the logic no longer depends on the entity it is on.Changes proposed:
rayOrigintype to/fromxrselectand when entering/leaving XRselectendfrom a different input source would incorrectly reset theactiveXRInputfreezing the active input source.