Added 'stencil' property to renderer system for enabling stencil buffer on WebGL context#5509
Conversation
|
Thanks! |
|
since the AFRAME 1.5.0 => 1.6.0 the stencil-code of the https://xrfragment.org demoviewer is now in a catch22: if I enable
Any idea whether there some other factors at play here besides bugs in my stencilcode? |
|
@coderofsalvation Three.js changed the default to no longer create a stencil buffer. This PR simply adds a way to re-enable it. So with The regression in your case is probably caused by a different change (possible in Three.js). Quickest way to find out is using |
|
@mrxz thanks for reminding. So yes it UPDATEIndeed THREE seems to be the culprit |
Description:
Since Three.js version r163 the stencil buffer is disabled by default. Existing components that rely on it being present might now be broken, for example: mrxz/fern-aframe-components#1. This PR introduces a
stencilproperty on the renderer system, similar to thealphaproperty, which is passed to theWebGLRendererconstructor, ensuring the relevant buffer will be created on the WebGL context.Changes proposed:
stencilproperty to renderer system