Update package.json shelljs dependabot Severity High 7.1 / 10#5497
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Nov 12, 2024
Merged
Update package.json shelljs dependabot Severity High 7.1 / 10#5497dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
Member
|
Yeah it's used to deploy the examples. This is also a dev dependency. not bundled in the library |
Contributor
Author
|
dependabot do not like it :) i could not test it, but would be nice to include the update |
Member
|
We gotta make sure there are no regressions. Also is a dev dependency that it's only used for A-Frame deployment. Pretty safe to ignore those warnings. |
Contributor
Author
|
i understand, but for some securty audits ( iso ) this is not allowed |
Member
|
I'll merge this and fingers crossed there's no regressions :) Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
https://access.redhat.com/security/cve/cve-2022-0144
@dmarcos the shelljs is only used in the https://github.com/aframevr/aframe/blob/master/scripts/preghpages.js
is this still used?