Remove attribute from DOM when removing component (through mixin removal/update)#5492
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Mar 7, 2024
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Components on an entity are reflected in the DOM. In case an entities mixins change, some of its components might end up getting removed (a-entity.js#L614-L615). In this case the DOM attribute would remain. This PR ensures that, similar to
initComponentthe change is reflected in the DOM if not done already.Changes proposed:
removeComponentis called without being caused by aremoveAttributecall.