Pass system name to parseProperties for proper warning messages#5463
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Feb 14, 2024
Merged
Pass system name to parseProperties for proper warning messages#5463dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Setting an unknown property for a system resulted in an incomplete warning message, for example:
The name of the system wasn't passed along to
parsePropertiesresulting in the name becomingundefined. This PR fixes the properties passed toparseProperties.Changes proposed:
parsePropertiesfor proper warning messagesfalseinstead ofundefinedfor boolean argumentgetPartialData