Fix bug when checking schema properties for schemaChange#5426
Merged
dmarcos merged 2 commits intoaframevr:masterfrom Jan 8, 2024
Merged
Fix bug when checking schema properties for schemaChange#5426dmarcos merged 2 commits intoaframevr:masterfrom
dmarcos merged 2 commits intoaframevr:masterfrom
Conversation
Member
|
Is it possible to cover the fix with a test? |
Contributor
Author
|
Added a couple unit tests covering schemaChange/udpateSchema (there were non before) including one covering the fixed behaviour. |
Member
|
Thanks! |
Contributor
|
@mrxz There is a related error in the aframe-inspector demo page. I didn't have time to investigate but it's exactly on the same line you just changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Components that have one or more properties marked as
schemaChangewill check if any of these properties change to trigger anupdateSchema. While checking the properties in an update, it incorrectly assumes each property to also exist, which might not be the case.Reproduction (https://glitch.com/edit/#!/beaded-basalt-church?path=index.html):
Changes proposed:
schemaChangeflag