Use correct default value (null) for glslVersion for non-raw shaders#5388
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Nov 17, 2023
Merged
Use correct default value (null) for glslVersion for non-raw shaders#5388dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
Member
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As reported by @vincentfretin on the aframe-environment-component: supermedium/aframe-environment-component#96
When registering non-raw shaders, a warning would be logged by Three.js indicating that the
glslVersionwas undefined. This was introduced in #5328 when addressing related changes in Three.js. However, the 'default' value ofundefinedfor non-raw shaders is incorrect and the cause of these warnings.Looking at the Three.js source, it's clear the default value is
null(ShaderMaterial.js#L53). Changing this resolves the issue.Changes proposed:
glslVersionvalue fromundefinedtonullmatching Three.js default