Hide fullscreen button in desktop mode on iPad#5191
Conversation
|
Is there any error in console? Fullscreen API not working on iPads? I tried quickly on one and the browser is entering some form of fullscreen mode (notice the x button on the top / left corner). I would investigate a bit more why we're rendering black |
|
I don't know if there is an error or not, I have no idea how to get console.log on iPad Safari. I tried using VorlonJS last time but couldn't make it work anymore. I don't have any macOS. |
|
I couldn't see any errors in console. Safari behavior is really bizarre. The fullscreen seems to engage: denoted by the X button on the top-left corner. Nothing renders but one can tap the x to exit the mode. I couldn't find any info anywhere about why this behavior. If fullscreen is really not available on iPad I would expect an error. As usual Safari is frustrating. Gonna merge this but hopefully we find a better way to handle this. |
Description:
As discussed in #4814 hide the fullscreen button on iPad in desktop mode when
cardboardModeEnabledisfalse, it just rendered a black screen.Changes proposed:
utils.device.isMobileDeviceRequestingDesktopSite()to detect desktop mode on iPad