Skip to content

Encoding should match scene's color management settings#5157

Merged
dmarcos merged 1 commit intoaframevr:masterfrom
diarmidmackenzie:fix-5014
Nov 20, 2022
Merged

Encoding should match scene's color management settings#5157
dmarcos merged 1 commit intoaframevr:masterfrom
diarmidmackenzie:fix-5014

Conversation

@diarmidmackenzie
Copy link
Contributor

@diarmidmackenzie diarmidmackenzie commented Nov 19, 2022

Description:

Fix for #5014

Changes proposed:

  • encoding setting for screenshot is read from renderer, rather than assuming sRGB or Linear
  • unit tests to check interaction between colorManagement setting on scene, and encoding used in screenshots.

@dmarcos
Copy link
Member

dmarcos commented Nov 20, 2022

Thank you so much! 🏆 🥳

@dmarcos dmarcos merged commit 11bdac3 into aframevr:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants