5144 rename throttle component changed#5151
Merged
dmarcos merged 4 commits intoaframevr:masterfrom Nov 18, 2022
Merged
Conversation
Contributor
vincentfretin
left a comment
There was a problem hiding this comment.
This looks good to me.
dmarcos
reviewed
Nov 15, 2022
src/utils/index.js
Outdated
| * Identical to throttleLeadingAndTrailing. | ||
| * Exists for back-compatibility with 1.3.0. | ||
| */ | ||
| module.exports.throttleComponentChanged = module.exports.throttleLeadingAndTrailing; |
Member
There was a problem hiding this comment.
I think we can just rename. Don't think many were relying on this. We can add a deprecation in next release notes.
Contributor
Author
There was a problem hiding this comment.
OK - removed this. What needs to happen to make sure this gets tracked for the release note?
dmarcos
reviewed
Nov 15, 2022
|
|
||
| A context such as `this` can be provided to handle function binding for convenience. | ||
|
|
||
| The same as [lodash's`throttle`][lodash], with `leading` and `trailing` options both set to `true` |
Member
There was a problem hiding this comment.
wonder if this reference is a liability long term in case lodash API changes.
Contributor
Author
There was a problem hiding this comment.
Maybe, but the existing docs already reference loadash throttle (the same link)
This doesn't make the situation any worse, I think.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PR as per #5144
Changes proposed: