Add suppport for Meta Quest Touch Pro controllers (fix #5138)#5140
Closed
felixtrz wants to merge 3 commits intoaframevr:masterfrom
felixtrz:questPro
Closed
Add suppport for Meta Quest Touch Pro controllers (fix #5138)#5140felixtrz wants to merge 3 commits intoaframevr:masterfrom felixtrz:questPro
felixtrz wants to merge 3 commits intoaframevr:masterfrom
felixtrz:questPro
Conversation
dmarcos
reviewed
Oct 20, 2022
| } else { | ||
| controllerMatch = profiles.length > 0 && profiles[0].startsWith(idPrefix); | ||
| if (idPrefix === 'oculus-touch') { | ||
| controllerMatch = profiles.length > 0 && (profiles[0].startsWith(idPrefix) || profiles[0].startsWith('meta-quest-touch')); |
Member
There was a problem hiding this comment.
profile ids should not be hard coded here. Something is not working higher in the call chain
Contributor
Author
There was a problem hiding this comment.
Please feel free to commandeer this and make changes or just reference the changes made here in #5139. Hard coding it definitely is not a good solution, but I wasn't sure what you would like to do here to handle the two prefix mapping to one control problem
Contributor
Author
There was a problem hiding this comment.
profile ids should not be hard coded here. Something is not working higher in the call chain
Happy to test out any new changes you make!
Member
There was a problem hiding this comment.
I made changes to #5139 Can you give it another try? Thanks
Member
|
Closing in favor of #5139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A patch for #5139