Add ability to use grip instead of targetRay space#5040
Merged
dmarcos merged 2 commits intoaframevr:masterfrom Apr 21, 2022
Merged
Add ability to use grip instead of targetRay space#5040dmarcos merged 2 commits intoaframevr:masterfrom
dmarcos merged 2 commits intoaframevr:masterfrom
Conversation
Member
|
Thanks. What’s the use case? |
Contributor
Author
|
I was working on a physics hands demo where I was using just tracked-controls to get controller position and wanted some cubes to stand in for hands, but they'd automatically be centered at the target ray point instead of just being in the center of my hands. It would also be useful if you're simulating something like the player holding a sword or other tool, which would make less sense being based around the target ray point. I just think this is easier than having to manually get references to the refSpace and frame, calling getPose on that, and then setting it or having to apply some manual offset to the controller position. |
Member
|
Thanks for the PR and patience! Great stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
tracked-controls-webxrcurrently usestargetRaySpaceto report controller pose with no option to change it. This PR adds the ability to specifygripSpaceovertargetRaySpace, while still keepingtargetRaySpaceas the default.Changes proposed:
spaceproperty on bothtracked-controlsandtracked-controls-webxrto allow the user to specifygripSpaceovertargetRaySpace.