Skip to content

fix component.events singleton, events being overridden by components of the same type#4250

Merged
dmarcos merged 1 commit intoaframevr:masterfrom
ngokevin:eventsfix
Aug 7, 2019
Merged

fix component.events singleton, events being overridden by components of the same type#4250
dmarcos merged 1 commit intoaframevr:masterfrom
ngokevin:eventsfix

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 7, 2019

Description:

Two component instances of same type using events API would interfere with each other.

Changes proposed:

  • Don't overwrite the events prototype with a binded version.

@dmarcos dmarcos merged commit 40b4465 into aframevr:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants