Fix a-asset-item binary glTF file loading#4228
Merged
ngokevin merged 2 commits intoaframevr:masterfrom Jul 27, 2019
Merged
Conversation
Member
|
This breaks loading of the glTF file loading in examples: On console:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes loading of binary glTF files by determining the file type using the glTF header. #4219
Changes proposed:
/file.glb?version=1). This fix checks for the presence of the glTF magic number in the response body to determine if it should be treated as binary glTF data or text.