Skip to content

isMobileVR distinguishes Samsung Internet for Gear VR from Samsung Internet for Android#4188

Merged
dmarcos merged 2 commits intoaframevr:masterfrom
DougReeder:master
May 28, 2019
Merged

isMobileVR distinguishes Samsung Internet for Gear VR from Samsung Internet for Android#4188
dmarcos merged 2 commits intoaframevr:masterfrom
DougReeder:master

Conversation

@DougReeder
Copy link
Contributor

Description:
Fixes issue #4187
#4187

Changes proposed:
Samsung Internet for Gear VR has "Mobile VR" in the useragent where Samsung Internet for Android has "Mobile", so the existing regex clause that checks for Mobile VR will return true for the Gear VR version and false for the Android version.

@dmarcos
Copy link
Member

dmarcos commented May 27, 2019

The test would return false for Go / GearVR versions of Samsung Internet. We need a different way to discriminate. What's the complete userAgent string for Samsung Internet in Go / GearVR?

Side note. We don't submit A-Frame builds as part of PRs

@DougReeder
Copy link
Contributor Author

Format of userAgent matches https://developer.samsung.com/internet/user-agent-string-format for devices I can test, with $(UX RECOMMEND) being "Mobile" on Android and "Mobile VR" on Gear VR.

I don't have a Go to check what it is there.

@dmarcos
Copy link
Member

dmarcos commented May 27, 2019

Thanks. it looks good if we can verify that the function returns true in Oculus Go.

Can you remove the dist and index.js files from the PR?

@dmarcos
Copy link
Member

dmarcos commented May 27, 2019

Thanks. it looks good if we can verify that the function returns true in Oculus Go for Samsung Internet.

Can you remove the dist and index.js files from the PR?

@dmarcos
Copy link
Member

dmarcos commented May 28, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants