Skip to content

Incorrect labelling of HTML tag in the image#2759

Merged
ngokevin merged 2 commits intoaframevr:masterfrom
ShaguftaMethwani:patch-1
Jun 12, 2017
Merged

Incorrect labelling of HTML tag in the image#2759
ngokevin merged 2 commits intoaframevr:masterfrom
ShaguftaMethwani:patch-1

Conversation

@ShaguftaMethwani
Copy link
Contributor

@ShaguftaMethwani ShaguftaMethwani commented Jun 12, 2017

Description:

  • The closing tag of HTML is labelled as the 'Opening tag'

Changes proposed:

  • A different image with correct labels

The closing tag of HTML is labelled as the 'Opening tag'
@ngokevin
Copy link
Member

I think the image looks fine, img doesn't need a closing tag and your image is served straight from raw.git which isn't a cdn

@ngokevin ngokevin closed this Jun 12, 2017
@ShaguftaMethwani
Copy link
Contributor Author

It was in the a-box tag, but yes not a cdn. Nevermind.

@ngokevin
Copy link
Member

Oh, I see.

@ngokevin ngokevin reopened this Jun 12, 2017
@ngokevin
Copy link
Member

Oh, I see! Sorry. That looks great. If you drag your image into any GitHub issue / pull request comment box, it will upload to CDN.

@ShaguftaMethwani
Copy link
Contributor Author

I'll change the url

@ngokevin ngokevin merged commit fd1a20d into aframevr:master Jun 12, 2017
@ngokevin
Copy link
Member

Thanks! Nice image editing work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants