Skip to content

Added contributing.md link#1767

Merged
ngokevin merged 3 commits intoaframevr:masterfrom
gurumukhi:patch-1
Aug 12, 2016
Merged

Added contributing.md link#1767
ngokevin merged 3 commits intoaframevr:masterfrom
gurumukhi:patch-1

Conversation

@gurumukhi
Copy link
Collaborator

No description provided.

README.md Outdated

## Contributing

Get involved! Check out the [Contributing Guide](CONTRIBUTING.md) on how to get started!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, maybe change the last exclamation mark to a period. So we don't yell it twice :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, on how to get started to for how to get started

@gurumukhi
Copy link
Collaborator Author

@ngokevin i think we are finally good to merge this ;-)

@mkungla
Copy link
Contributor

mkungla commented Aug 12, 2016

@gurumukhi can you please squash your commits into one

@ngokevin
Copy link
Member

We can squash from GitHub :)

Thanks!

@ngokevin ngokevin merged commit 9e5bbce into aframevr:master Aug 12, 2016
@gurumukhi
Copy link
Collaborator Author

Thanks.

@ngokevin, For my information.. can I squash the commits on github UI itself?

@ngokevin
Copy link
Member

There's an option to squash during the merge process on GitHub. I just did that when merging.

@mkungla
Copy link
Contributor

mkungla commented Aug 12, 2016

@gurumukhi nothing to worry about. I did not know that github has squash opt for PR's

@gurumukhi
Copy link
Collaborator Author

@mkungla I also didn't know :-D

& Thanks @ngokevin for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants