Skip to content

Reconsider default maxCanvasWidth and maxCanvasHeight values #5413

@mrxz

Description

@mrxz

Description:
By default the renderer resolution is capped at 1920x1920. This was introduced back in 2018 with #3641. There are a couple of downsides to this:

  • Screen resolutions have gone up, making it likely that this cap is hit in everyday configurations
  • Exceeding the cap might go unnoticed, or the resulting blurriness can be difficult to attribute to this cap
  • The width and height take devicePixelRatio into account, which is inconsistent with Three.js ("device pixels" vs "CSS pixels")

I would propose changing the default values to -1 making it uncapped by default. Users can always opt-in to capping the size if they have a specific need for it.
Otherwise it wouldn't hurt log a warning in the console once the cap is exceeded and possible increase the default cap.

  • A-Frame Version: 1.5.0
  • Platform / Device: all

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions