Skip to content

Plugin Dependencies: Require the class in Core's bootstrap, but just don't initialize it during tests.#16

Merged
afragen merged 2 commits intoafragen:dependencies-tabfrom
costdev:require_pd_but_just_dont_initialize_during_tests
Feb 5, 2024
Merged

Plugin Dependencies: Require the class in Core's bootstrap, but just don't initialize it during tests.#16
afragen merged 2 commits intoafragen:dependencies-tabfrom
costdev:require_pd_but_just_dont_initialize_during_tests

Conversation

@costdev
Copy link
Copy Markdown

@costdev costdev commented Feb 5, 2024

Previously, the inclusion of the WP_Plugin_Dependencies() was also conditional, causing a Fatal Error during test runs with internal callstacks requiring it.

This moves the require_once out of the conditional.

costdev added 2 commits February 5, 2024 03:48
…itional.

Previously, the inclusion of the `WP_Plugin_Dependencies()` was also conditional,
causing a Fatal Error during test runs with internal callstacks requiring it.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @me@colin-stewart.co.uk.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: .

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: me@colin-stewart.co.uk.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afragen afragen merged commit 31f6f95 into afragen:dependencies-tab Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants