Make the branch switching list table row visually incorporated into the row for the plugin/theme it is for...#898
Merged
afragen merged 3 commits intoafragen:developfrom Sep 8, 2020
Merged
Conversation
…he row for the plugin/theme it is for, just like normal update rows. Also adds the git host icon to the branch switching row in the same place where normal update rows have the "recycle" icon, to make it more clear that that row is added by GHU.
Contributor
Author
|
Andy, this avoids the problem we discussed on Slack where the "branch switching row" would be updated when applying a shinny update :-) |
afragen
reviewed
Sep 8, 2020
afragen
reviewed
Sep 8, 2020
Owner
|
I found an edge case. The row line appears when a plugin is active and my Local Development plugin is active with it.
I'm not sure what the issue is. Confirmed in both Safari and Chrome. |
Owner
|
Thanks Paul! |
afragen
added a commit
that referenced
this pull request
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..., just like normal update rows,
Also adds the git host icon to the branch switching row in the same place where normal update rows have the "recycle" icon, to make it more clear that that row is added by GHU.
With this PR applied, the plugins screen might look like: