Add spectral noise reduction (NR2) with FFTW3 integration#79
Merged
Conversation
- Implement Ephraim-Malah MMSE-LSA noise reduction with OSMS floor tracking - Add FFTW3 support for optimized FFTs with a built-in radix-2 fallback - Add background FFTW wisdom generation with modal UI progress dialog - Add setup-fftw.ps1 script to automate Windows x64 dependency setup - Add NR2 toggle to VFO DSP panel and handle mono processing in AudioEngine
Collaborator
|
Merged — excellent work @EI6JGB! The Ephraim-Malah implementation is clean and well-engineered. The FFTW3/radix-2 fallback architecture is exactly right. See Discussion #77 for community input on optimizing the wisdom generation (background thread + lazy planning). Looking forward to hearing how NR2 performs on weak signals. 73 de KK7GWY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-fftw.ps1script to automate Windows x64 dependency setupFiles changed
src/core/SpectralNR.cpp,src/core/SpectralNR.hsrc/core/AudioEngine.cpp,src/core/AudioEngine.hsrc/gui/MainWindow.cpp,src/gui/VfoWidget.cpp,src/gui/VfoWidget.hCMakeLists.txt,setup-fftw.ps1third_party/fftw3/(headers, lib, DLL)Test plan
third_party/fftw3— verify DLL is copied to build dir🤖 Generated with Claude Code